More Chat Indicators (electric boogaloo)

[kotobdev]

About the PR

Revival of https://github.com/DeltaV-Station/Delta-v/pull/3932. Your chat indicator changes based on if you're using the radio/whispering/emoting/LOOC-ing. genuinely game changing feature and i cannot let it sit in a closed PR

Draft PR because: needs new sprites (idle and active states, plus i'm just not the biggest fan of the current ones) and if I can convince somebody to make them for me, I'll give them at least one metafriend token. ping me on discord if you are a true aseprite gamer

Why / Balance

see original. also design doc direction approved!

Technical details

see original

Media

see original for video but tl;dr

Requirements

• [ ] I have tested all added content and changes.
• [X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl: Nesoryo, Nikovnik, kotobdev

• add: Added alternative typing indicators for whispering, emoting and when talking into radio or (L)OOC

[github-actions[bot]]

RSI Diff Bot; head commit dbcc2b6163e02fbef332bd3798d15ff4692fa5e6 merging into a101aabb542917dec2ca82eac7dd9e3b4775e1e7 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Effects/speech.rsi

State	Old	New	Status
emote0			Added
emote1			Added
ooc0			Added
ooc1			Added
radio0			Added
radio1			Added
whisper0			Added
whisper1			Added

Edit: diff updated after dbcc2b6163e02fbef332bd3798d15ff4692fa5e6

[ShepardToTheStars]

@kotobdev Are you still working on this?

[kotobdev]

@kotobdev Are you still working on this?

Yeah, just got caught up with other stuff, I'll finish it up soon

[kotobdev]

this is about as good as it's gonna get, so opening for review. CI shall decide my fate

[ShepardToTheStars]

Testing this currently.

Things that work fine:

• Using chat shortcuts (like :m, @, [, etc.)

Things that are really janky

• Switching chat channels with tab
• Selecting chat channels by clicking on the chat channels

I'll see if there's an easy way of getting the janky ones to work more consistently, but the few things I've tried don't work as well (like the putting the new NotifySpecificChatChannel function in SafelySelectChannel, OnInputKeyBindDown, OnFocusEnter.)

I'm wondering if it has to do with the functions it calls in ChatUiController.cs or TypingIndicatorSystem.cs

    public void NotifyChatTextChange()
    {
        _typingIndicator?.ClientChangedChatText();
    }

    public void NotifyChatFocus(bool isFocused)
    {
        _typingIndicator?.ClientChangedChatFocus(isFocused);
    }

[ShepardToTheStars]

Alright, I think I got a decent way to handle those janky cases.

I'll suggest some changes.

[kotobdev]

Done, feels WAY less janky now. Thanks for the help!