Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Directional tinted window have full tile shadows.

Open FieldCommand opened this issue 1 month ago • 2 comments

Description

Directional tinted windows have a full tile shadow, this also include reinforced variant.

Reproduction

Place directional tinted window. Done.

Screenshots

Image

Additional context

N/A

FieldCommand avatar Nov 12 '25 20:11 FieldCommand

100% caused by this PR in the last upstream merge. https://github.com/space-wizards/space-station-14/pull/38276

Can be disabled at the moment by unchecking 'Show Ambient Occlusion' if you'd like. But I'll look for a fix. Image

ShepardToTheStars avatar Nov 13 '25 00:11 ShepardToTheStars

So, I looked at the ambient occlusion code a few days ago. If something is given the OcclusionComponent, the new ambient occlusion code will create an overlay and apply some shaders. If an object has the OcclusionComponent, it assumes that it takes up the whole tile rather than just a portion of the tile and shades the entire tile. This is probably because upstream does not have a version of the tinted windows, and didn't need to account for tiles that contained an occluding object that was smaller than the entire tile.

It looks at the texture size but does not account for transparent pixels.

ShepardToTheStars avatar Nov 15 '25 18:11 ShepardToTheStars