Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Bring Ovni back

Open Bonktrauma opened this issue 1 month ago • 20 comments

About the PR

Refurbished Ovni station from the prebase, majority of the work was done by Deltanedas, i just revived it and did the changes requested, along with add some newer things like the archivist

Why / Balance

I wanted ovni back

Technical details

Readded Ovni Eddited turrets added archivist, fixed alot of requested changes

Media

Screenshot 2025-11-03 162930

Requirements

  • [x] I have tested all added content and changes.
  • [x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl: MAPS

  • add: Readded Ovni

Bonktrauma avatar Nov 04 '25 01:11 Bonktrauma

Oops, aa remains, removal time

Bonktrauma avatar Nov 04 '25 01:11 Bonktrauma

I have no idea why the test is failing

Bonktrauma avatar Nov 04 '25 10:11 Bonktrauma

Last update added LO suit, ready for review btw

Bonktrauma avatar Nov 14 '25 09:11 Bonktrauma

Relevant test fail.

SERVER: 1.087s [ERRO] entity_deserializer: Encountered invalid EntityUid reference wile reading entity 12123, component: DeviceNetwork

- proto: FirelockEdge
  entities:
   # ...
  - uid: 12123
    components:
    - type: Transform
      rot: -1.5707963267948966 rad
      pos: 56.5,-21.5
      parent: 8
    - type: DeviceNetwork
      configurators:
      - invalid
      deviceLists:
      - 515

Looks like its a firelock connected to a freezer air alarm? Maybe replace it and re-configure it?

- proto: AirAlarmFreezer
  entities:
  - uid: 515
    components:
    - type: Transform
      pos: 58.5,-18.5
      parent: 8
    - type: DeviceList
      devices:
      - 10682
      - 11296
      - 12090
      - 12051
      - 11293
      - 12091
      - 12123

ShepardToTheStars avatar Nov 18 '25 19:11 ShepardToTheStars

Relevant test fail.

SERVER: 1.087s [ERRO] entity_deserializer: Encountered invalid EntityUid reference wile reading entity 12123, component: DeviceNetwork

- proto: FirelockEdge
  entities:
   # ...
  - uid: 12123
    components:
    - type: Transform
      rot: -1.5707963267948966 rad
      pos: 56.5,-21.5
      parent: 8
    - type: DeviceNetwork
      configurators:
      - invalid
      deviceLists:
      - 515

Looks like its a firelock connected to a freezer air alarm? Maybe replace it and re-configure it?

- proto: AirAlarmFreezer
  entities:
  - uid: 515
    components:
    - type: Transform
      pos: 58.5,-18.5
      parent: 8
    - type: DeviceList
      devices:
      - 10682
      - 11296
      - 12090
      - 12051
      - 11293
      - 12091
      - 12123

How the hell do i find which air alarm

Bonktrauma avatar Nov 18 '25 22:11 Bonktrauma

Err, firelock

Bonktrauma avatar Nov 18 '25 22:11 Bonktrauma

Think i got it

Bonktrauma avatar Nov 18 '25 22:11 Bonktrauma

that should have done it..?

Bonktrauma avatar Nov 18 '25 22:11 Bonktrauma

test fail seems real

Toby222 avatar Nov 18 '25 22:11 Toby222

test fail seems real

I dont know what's causing it, I replaced the firelock causing the issue above im pretty sure

Bonktrauma avatar Nov 18 '25 22:11 Bonktrauma

test fail seems real

I dont know what's causing it, I replaced the firelock causing the issue above im pretty sure

14 separate instances of 1) SERVER: 50.091s [ERRO] entity_deserializer: Encountered invalid EntityUid reference wile reading entity 5361, component: DeviceNetwork Exception: on different entity IDs All of them, when you look at them, have

    - type: DeviceNetwork
      configurators:
      - invalid

I don't know how mapping works but seems like something happened when you deleted the configurator you used while mapping

In theory, just removing the configurators property on those entities should suffice but again, I'm no mapper

Toby222 avatar Nov 18 '25 22:11 Toby222

Talk to me in the mapping channel. Easier to explain there

IamVelcroboy avatar Nov 18 '25 23:11 IamVelcroboy

Please add your name to the attribution file in Resources/deltav_map_attributions.yml

IamVelcroboy avatar Nov 20 '25 18:11 IamVelcroboy

Please add your name to the attribution file in Resources/deltav_map_attributions.yml

Ok

Bonktrauma avatar Nov 20 '25 22:11 Bonktrauma

Please add your name to the attribution file in Resources/deltav_map_attributions.yml

Done

Bonktrauma avatar Nov 20 '25 22:11 Bonktrauma

@ShepardToTheStars hey tests are failing again, know what's going on?

Bonktrauma avatar Nov 28 '25 04:11 Bonktrauma

You still have invalids Screenshots_2025-11-27-23-14-33

IamVelcroboy avatar Nov 28 '25 05:11 IamVelcroboy

You still have invalids Screenshots_2025-11-27-23-14-33

I didnt see this, but I alr went through to remove them

Bonktrauma avatar Nov 28 '25 05:11 Bonktrauma

fails KEEP COMING BACK!!!

Bonktrauma avatar Nov 28 '25 07:11 Bonktrauma

i have no idea what that last commit is

Bonktrauma avatar Nov 28 '25 07:11 Bonktrauma