fix the tails

[AeraAuling]

About the PR

This is just sprite stuff. Specifically, it alters our sprites. There are sprites from other forks which will have the issue I am trying to fix. That issue in this case is that there are pixels from tail markings that show up between legs. Due to how markings are layered, these pixels show up over clothes. What this does is make something that is barely noticeable when wearing pants, and far too noticeable when wearing skirts and makes them all look like shorts instead. Now people who use the afflicted tails can wear skirts too instead of having tail enforced shorts.

Why / Balance

hatred and spite for layering

Technical details

sprites

Media

Before: After:

Requirements

• [x] I have tested all added content and changes.
• [x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

• tweak: certain tails no longer make skirts look like shorts

[github-actions[bot]]

RSI Diff Bot; head commit 5604de91657f879c8e134e2344c11459870ebdf6 merging into acf7b12c87e87aa3c7534455217fa24c82c8b4c1 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Mobs/Customization/Felinid/tiger_tail.rsi

State	Old	New	Status
m_tail_tiger_primary			Modified

Resources/Textures/_DV/Mobs/Customization/Feroxi/tail_markings.rsi

State	Old	New	Status
feroxi-tail			Modified

Resources/Textures/_DV/Mobs/Customization/Moth/moth_wings.rsi

State	Old	New	Status
selene			Modified
selene_primary			Modified

Resources/Textures/_DV/Mobs/Customization/Rodentia/tail_markings.rsi

State	Old	New	Status
mouse			Modified
short			Modified

Resources/Textures/_DV/Mobs/Customization/Vulpkanin/tail_markings.rsi

State	Old	New	Status
fennec			Modified
fox			Modified
fox2			Modified
fox3			Modified
otie			Modified
vulp			Modified
vulp_alt			Modified
vulp_wag			Modified

Resources/Textures/_DV/Mobs/Customization/kitsune/tails.rsi

State	Old	New	Status
foxninetailstone1			Modified
foxthreetailstone1			Modified
foxtwotailstone1			Modified
kitsune_primary			Modified

Edit: diff updated after 5604de91657f879c8e134e2344c11459870ebdf6

[kotobdev]

worth noting, i think Floof fixed the same thing (at least it LOOKS like the same thing) in a bit of a different way without modifying the sprites - if you want to check out how they did it, https://github.com/Floof-Station/Floof-Station/pull/742

still, probably nothing wrong with this approach though, if it works it works

[NoElkaTheGod]

This does not, in fact, work. It fixes those specific 2 pixels, but the overall problem persists. Heck, even the screenshots show that tails still clip through half of the skirt, and don't even get me started on nine-tail kitsune (can't even have mantles with those). That PR from Floof seems to be the ideal solutiuon, but holy fuck it's 13k lines. I feel sorry for whoever is brave enough to port that.

[AeraAuling]

This does not, in fact, work. It fixes those specific 2 pixels, but the overall problem persists. Heck, even the screenshots show that tails still clip through half of the skirt, and don't even get me started on nine-tail kitsune (can't even have mantles with those). That PR from Floof seems to be the ideal solutiuon, but holy fuck it's 13k lines. I feel sorry for whoever is brave enough to port that.

it works insofar in that it stops the altered tails from making skirts not look like shorts anymore. it's not a perfect solution, but it's a solution to that specific issue until someone wants to take on the task of porting a 13k lines changed feature

[kotobdev]

This does not, in fact, work. It fixes those specific 2 pixels, but the overall problem persists. Heck, even the screenshots show that tails still clip through half of the skirt, and don't even get me started on nine-tail kitsune (can't even have mantles with those). That PR from Floof seems to be the ideal solutiuon, but holy fuck it's 13k lines. I feel sorry for whoever is brave enough to port that.

fwiw the "fix" part of the PR is relatively small, most of the lines come from the fact it's porting two morbillion tail sprites from ss13 at the same time for some reason, we can just ignore that part of it. aside from that, most of the actual yaml being touched is just one- or two-line additions to each species prototype

[ShepardToTheStars]

I'll take a look at this sometime soon.

[Mnemotechnician]

worth noting, i think Floof fixed the same thing (at least it LOOKS like the same thing) in a bit of a different way without modifying the sprites - if you want to check out how they did it, Floof-Station/Floof-Station#742

I am from Floof, and I can tell you our way of doing it is not perfect either. It requires you to split each tail marking sprite into two: a layer that always draws over the character and a layer that always draws under the character, and then linking them together in the marking prototype. It does allow to create complex tail sprites, but unless that is your goal, I would recommend to create a system that reorders your character's sprite layers instead (when facing north, the tail should be drawn above all other layers; in all other cases it should be drawn under them).