Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

re-add colored turtlenecks

Open AveriV2 opened this issue 7 months ago • 2 comments

About the PR

Re-added colored turtlenecks into the game after upstream nuked them.

Why / Balance

No reason for it to be removed! :(

Technical details

Adds stuff to winterdrobe.yml and stuff

Media

446807662-b8bdd574-f547-4a06-9f9f-7cd7b1a89be6

Requirements

  • [X] I have tested all added content and changes.
  • [X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

i hope none Changelog

:cl: Ko4erga , AveriV2

  • add: Added colored turtlenecks back into the game!

AveriV2 avatar May 23 '25 01:05 AveriV2

RSI Diff Bot; head commit 7a4d3e0daf148ff0a2fcb79774c82ebfea62cf0c merging into cc9255c421414b117ea59bc17d8f69a6e4094fe3 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Uniforms/Jumpskirt/color_turtle.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added
skirt-equipped-INNERCLOTHING Added
skirt-icon Added
skirt-inhand-left Added
skirt-inhand-right Added
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/color_turtle.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added
trousers-equipped-INNERCLOTHING Added
trousers-icon Added
trousers-inhand-left Added
trousers-inhand-right Added
Edit: diff updated after 7a4d3e0daf148ff0a2fcb79774c82ebfea62cf0c

github-actions[bot] avatar May 23 '25 01:05 github-actions[bot]

put it in _DV and the vending machine entries before the end comment, not after

alright will do

AveriV2 avatar May 23 '25 13:05 AveriV2

put sprite and clothing paths in an abstract parent at least

i think what they did was intentional idk

AveriV2 avatar May 24 '25 15:05 AveriV2

copy pasting 20 things is just supercode

deltanedas avatar May 24 '25 16:05 deltanedas

copy pasting 20 things is just supercode

im gonna be real i dunno how to code, so... its the same code as it previously was in the game so i assume its fine

AveriV2 avatar May 25 '25 05:05 AveriV2

just make an abstract prototype with the sprite paths

- type: entity
  abstract: true
  parent: ClothingUniformBase
  id: ClothingTurtleneckBase
  components:
  - type: Sprite
    sprite: ...
  - type: Clothing
    sprite: ...

and change every turtleneck parent to it and remove the copy pasted sprite paths from them

deltanedas avatar May 25 '25 14:05 deltanedas

Wouldn't that require partial inheritance to work? If you touch every component, you don't get anything from an abstract parent innit?

Toby222 avatar May 26 '25 11:05 Toby222

its the same rsi in all of them

deltanedas avatar May 26 '25 14:05 deltanedas

ill TRY later today

AveriV2 avatar May 28 '25 14:05 AveriV2

its the same rsi in all of them

But not the same state and color and such, no?

Toby222 avatar Jun 03 '25 10:06 Toby222

the rsi is the thing that can be inherited

deltanedas avatar Jun 03 '25 10:06 deltanedas

So partial inheritance is real?

Toby222 avatar Jun 03 '25 10:06 Toby222

yes thats how it always worked

deltanedas avatar Jun 03 '25 10:06 deltanedas

oh god i never tried "later today" i should stop procastinating oh god

AveriV2 avatar Jun 05 '25 21:06 AveriV2

someone did it for me 😭

AveriV2 avatar Jul 19 '25 09:07 AveriV2