Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Oni Rebalance - Mythos

Open Avalon-Proto opened this issue 8 months ago • 36 comments

About the PR

This PR moves around quite a bit w/ Oni, including changing up their damage buffs, granting some new tricks, and more.

Why / Balance

Oni have been quite an interesting species, but with the introduction of kitsune and their moire mythology based abilities and quirks, I decided to set out on a PR to bring Oni to that same standard. Many good things are coming

Technical details

Lots of YML, 2 new items, and some mixups to the oni metabolism

Media

New Guidebook image Gourds image Uplink image The Drink image One Bible Slap image The power of the Axe image Sake Gourd in loadouts image

Requirements

  • [x] I have tested all added content and changes.
  • [x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Oni across the system feel reinvigorated and changed. And closer to their ancestors of old
  • add: An oni's best friend a drinking gourd, has been found in the hands of many of our crewmembers. Found under the trinkets tab
  • add: The syndicate's nefarious plots have brewed up a new cocktail, Beast's blood, for their oni agents. Let the hunt begin, and their prey fall before them

Avalon-Proto avatar Apr 23 '25 13:04 Avalon-Proto

Yes

Bonktrauma avatar Apr 24 '25 02:04 Bonktrauma

RSI Diff Bot; head commit ed09864da8087f8a1ee058ba36c0c315253aa2c0 merging into ccde7f31641f9f92b433bc24d2c7ad93e6020030 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Objects/Specific/Species/Oni/cybergourd.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
Resources/Textures/_DV/Objects/Specific/Species/Oni/gourd.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
Edit: diff updated after ed09864da8087f8a1ee058ba36c0c315253aa2c0

github-actions[bot] avatar Apr 26 '25 05:04 github-actions[bot]

@deltanedas I have no idea why, but my reagent for BeastBlood is broken and not spawning

Avalon-Proto avatar Apr 26 '25 05:04 Avalon-Proto

your healthchanged at the bottom is missing a value, read yml linter

deltanedas avatar Apr 26 '25 10:04 deltanedas

The gourds should be in the same RSI, different state.

Why not 2 separate ones? They are similar yes but this makes it easier to keep them separate

Avalon-Proto avatar Apr 28 '25 00:04 Avalon-Proto

Ready fo review, just got a few finishing touches to throw onto it

Avalon-Proto avatar Apr 29 '25 03:04 Avalon-Proto

How do they deal asphyx? Also how heal holy damage...

KZhProgram avatar Apr 29 '25 04:04 KZhProgram

How do they deal asphyx? Also how heal holy damage...

Y'know I forgot to swap that to.stamina damage

Avalon-Proto avatar Apr 29 '25 10:04 Avalon-Proto

I love the gourd sprites and am always a fan of recharging consumables

Smugman avatar Apr 29 '25 12:04 Smugman

Test fails real :⁾

Toby222 avatar Apr 29 '25 15:04 Toby222

Test fails real :⁾

Yes yes I know ill fix em soonish

Avalon-Proto avatar Apr 29 '25 15:04 Avalon-Proto

Shit my Oni metabolism isnt working, why arent they taking less poison damage :elp:

Avalon-Proto avatar Apr 29 '25 18:04 Avalon-Proto

Now if only I knew why the ethanol wasn't using the reduced poison damage for Oni, but it is doing the no vomiting part

Avalon-Proto avatar May 01 '25 14:05 Avalon-Proto

Now if only I knew why the ethanol wasn't using the reduced poison damage for Oni, but it is doing the no vomiting part

You never changed the poison damage. You only changed the booze strength multiplier

Toby222 avatar May 01 '25 14:05 Toby222

You'd have to add it to the Alcohol metabolism effect similar to Dwarf

Toby222 avatar May 01 '25 14:05 Toby222

Oh my God I'm fucking dumb I accidentally deleted it when I was moving stuff around :elp:

Avalon-Proto avatar May 01 '25 15:05 Avalon-Proto

OKAY! So , beside the FTL not working for some reason, @Toby222 this PR is Allll set

Avalon-Proto avatar May 01 '25 23:05 Avalon-Proto

OKAY! So , beside the FTL not working for some reason, @Toby222 this PR is Allll set

Test fails real

Toby222 avatar May 02 '25 10:05 Toby222

It's not the ftl that's not working, you need to define a flavor prototype, then re request review :^)

Toby222 avatar May 02 '25 10:05 Toby222

It's not the ftl that's not working, you need to define a flavor prototype, then re request review :^)

I thought I did define a flavor prototype :elp:

Avalon-Proto avatar May 02 '25 10:05 Avalon-Proto

It's not the ftl that's not working, you need to define a flavor prototype, then re request review :^)

I thought I did define a flavor prototype :elp:

You didn't which is why I told you it wasn't before :3

Toby222 avatar May 02 '25 10:05 Toby222

Where do I define it then-

Avalon-Proto avatar May 02 '25 10:05 Avalon-Proto

Where do I define it then-

Resources/Prototypes/_DV/Flavors/flavors.yml

Toby222 avatar May 02 '25 10:05 Toby222

@Toby222 ITS DONE

Avalon-Proto avatar May 03 '25 03:05 Avalon-Proto

Alll changes fixed

Avalon-Proto avatar May 05 '25 23:05 Avalon-Proto

Alll changes fixed

Remember to re-request reviews when you want one :^)

Toby222 avatar May 07 '25 07:05 Toby222

@deltanedas Should be good now

Avalon-Proto avatar May 07 '25 11:05 Avalon-Proto

Direction here, apologies for lack of notification about review process. The post was taken in by a non-curator. We've had this in review for about 4 days.

Our consensus is that this is not the way we want to proceed with Oni, for the following reasons:

  • Their resistances and damages are already strong as is, they do not need significant increase. Holy damage is a mostly nonexistant damage type and one that may not see future use anyways.
  • The implementation of Beast's Blood leans into Oni's being a stereotypically brutish and violent species, which we are not interested in reinforcing. Nor are we comfortable with the possible caricature it portrays of the mythos being referenced.
  • Healing from alcohol is a strong buff, poorly connotated, and also essentially Wizden dwarves. We would prefer to do something different with Oni.

Generally speaking we are not looking to caricature species. We are aware of the similar implementation with Kanabous and Samuri Armor, and those may be reconsidered later.

There are varied feelings about the Gourd as a standalone item, so if it was PRd as a separate item for all traitors, it would be considered in a separate review.

Onis do need some changes to differentiate them and add excitement, but Direction does not want to take this approach.

ThataKat avatar May 08 '25 00:05 ThataKat

* Their resistances and damages are already strong as is, they do not need significant increase. Holy damage is a mostly nonexistent damage type and one that may not see future use anyways.

I didn't think this was too significant of a buff, but if it is too much I can always dial it back. As for the holy damage, while there are few sources of it, any one of them will HEAVILY damage an oni

* The implementation of Beast's Blood leans into Oni's being a stereotypically brutish and violent species, which we are not interested in reinforcing. Nor are we comfortable with the possible caricature it portrays of the mythos being referenced.

This PR was aiming to align them more with their mythos as a species, where Oni are an ogre like Yokai that tend to be more brutish and violent. But this does not mean that they all are. Its a baseline not the rule, and players can choose to ignore/change it to fit their characters

* Healing from alcohol is a strong buff, poorly connotated, and also essentially Wizden dwarves. We would prefer to do something different with Oni.

Oni in their mythology are heavy drinkers, known to seek the strongest and purest alcohol they can find. And why would it matter if they are similar to wizden's dwarves when we will likely never enable the dwarves

Generally speaking we are not looking to caricature species. We are aware of the similar implementation with Kanabous and Samuri Armor, and those may be reconsidered later.

This was not an attempt at caricature, I looked into the mythology of the oni to help me figure what i wanted to do with the PR. Samurai armor is commonly made with an Oni mask, and most depictions of oni have them carrying a kanabou

There are varied feelings about the Gourd as a standalone item, so if it was PRd as a separate item for all traitors, it would be considered in a separate review.

Which one? Or Both. If you want beasts blood, i will have to tone back the alcohol content cause I made it to basically kill anyone who wasn't an oni that drank too much of it

Avalon-Proto avatar May 08 '25 01:05 Avalon-Proto

The implementation of Beast's Blood leans into Oni's being a stereotypically brutish and violent species, which we are not interested in reinforcing. Nor are we comfortable with the possible caricature it portrays of the mythos being referenced.

Isn't this how Oni's are though? At least Wikipedia tells me that they had their evil nature manifesting in cannibalism and murder. But then again, I'm no history expert, and sometimes, Wikipedia isn't as reliable as I hope it to be. But I think the Beast's Blood Gourdon is a very thematically fitting accessory to buy! Also helps with Oni's needing melee weapons more than other species.

SirWarock avatar May 09 '25 02:05 SirWarock