Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard
verified publisher icon DeltaV-Station

Better insectoid glasses (round 2)

Open HTMLSystem opened this issue 1 year ago • 4 comments

About the PR

This adds custom sprites for arachnids and moths for all glasses and huds.

Why / Balance

It's so the glasses actually cover the species eyes. There are many players, myself included, that avoid wearing glasses and some huds (or have to use the eyepatches) because they look dumb on those species. This fixes that.

Technical details

Sprite stuff and whatnot.

Media

353158625-8226dbde-07bf-4c16-88e7-fda94e5c0c1c 353158648-2b4832d7-5157-40e3-aa11-124567cf6f49 353158661-0b10124c-d04c-41de-8231-3527e9d8df3b 353158674-39825ccb-f5ce-43da-a30c-d72f9a6fe87d 353158683-c831ff56-55c6-41a1-aecb-289088cef589 353158688-4ec7bc6e-ed92-4d4f-84d2-9a3811422ad3

Requirements

  • [X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A Changelog

Nuh uh

HTMLSystem avatar Aug 23 '24 18:08 HTMLSystem

RSI Diff Bot; head commit f04e4bb35fc9124881942cf2ac70d0f299b912ab merging into b0965ed2a41b2af524592aeaf0dae1530381aeef This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Eyes/Glasses/commandglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/gar.rsi

State Old New Status
alt-equipped-EYES-arachnid Added
equipped-EYES-arachnid Added
super-equipped-EYES-arachnid Added
Resources/Textures/Clothing/Eyes/Glasses/glasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/jamjar.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/jensen.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/mercglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/meson.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/ninjavisor.rsi

State Old New Status
equipped-EYES-arachnid Added
Resources/Textures/Clothing/Eyes/Glasses/outlawglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/science.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/secglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/sunglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Glasses/thermal.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/beergoggles.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
inhand-left Added
inhand-right Added
Resources/Textures/Clothing/Eyes/Hud/beerpatch.rsi

State Old New Status
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/command.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/diag.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/diagpatch.rsi

State Old New Status
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/friedonion.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/med.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/medonion.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/medonionbeer.rsi

State Old New Status
equipped-EYES-arachnid Added
inhand-left Added
inhand-right Added
Resources/Textures/Clothing/Eyes/Hud/medpatch.rsi

State Old New Status
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/medsec.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
inhand-left Added
inhand-right Added
Resources/Textures/Clothing/Eyes/Hud/medsecengi.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
inhand-left Added
inhand-right Added
Resources/Textures/Clothing/Eyes/Hud/omni.rsi

State Old New Status
equipped-EYES-arachnid Added
inhand-left Added
inhand-right Added
Resources/Textures/Clothing/Eyes/Hud/onionbeer.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/sec.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/secpatch.rsi

State Old New Status
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Hud/synd.rsi

State Old New Status
equipped-EYES-arachnid Added
Resources/Textures/Clothing/Eyes/Hud/syndagent.rsi

State Old New Status
equipped-EYES-arachnid Added
Resources/Textures/Clothing/Eyes/Misc/blindfold.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/Clothing/Eyes/Misc/eyepatch.rsi

State Old New Status
equipped-EYES-moth Added
Resources/Textures/_DV/Clothing/Eyes/Glasses/safetyglasses.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/_DV/Clothing/Eyes/Hud/prescmedhud.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Resources/Textures/_DV/Clothing/Eyes/Hud/prescsechud.rsi

State Old New Status
equipped-EYES-arachnid Added
equipped-EYES-moth Added
Edit: diff updated after f04e4bb35fc9124881942cf2ac70d0f299b912ab

github-actions[bot] avatar Aug 23 '24 18:08 github-actions[bot]

This is ready to be merged whenever.

HTMLSystem avatar Aug 23 '24 20:08 HTMLSystem

My habit of mispelling words strikes again. I'll fix those later. In the meantime you could dm me on discord (or I could dm you, whichever happens first) on PRing this upstream.

HTMLSystem avatar Aug 27 '24 02:08 HTMLSystem

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 30 '24 14:08 github-actions[bot]

So, the PR upstream has been in review for about a month and they seem a bit dead set on me using displacement maps for some of the glasses (which I'm not very willing to do). Would there be any problems if this is merged early here instead of waiting on upstream? Edit: I just realized I NEVER put the command glasses or admin hud glasses in here. I'll fix that really quick.

HTMLSystem avatar Oct 13 '24 14:10 HTMLSystem

The test fail seems unrelated? My dev environment boots up fine without any issues or warnings, and the yaml looks completely fine. None of the warnings look related either. Though maybe I'm overlooking something...

HTMLSystem avatar Oct 13 '24 15:10 HTMLSystem

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 20 '24 01:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 20 '24 02:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 01 '25 08:01 github-actions[bot]

Closing because it was merged upstream!!

HTMLSystem avatar Mar 07 '25 00:03 HTMLSystem