Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

add scarfs to all loadouts

Open portfiend opened this issue 1 year ago • 8 comments

About the PR

add scarfs to all loadouts (except prisoner and gladiator)

Why / Balance

was gonna add this to a downstream server but i was told by a project manager to add it here

Technical details

YAML warrior with my finest weapon "Ctrl-V"

a small note: if a scarf and another neck item are equipped at the same time it will drop the scarf (usually) on the floor when the person spawns

Media

Screenshot_135

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

:cl: portfiend

  • tweak: every loadout has scarfs now

portfiend avatar Jul 16 '24 12:07 portfiend

drafting because i hate this

portfiend avatar Jul 16 '24 15:07 portfiend

I really love scarves, and this is awesome.

Lyndomen avatar Jul 16 '24 16:07 Lyndomen

I really love scarves, and this is awesome.

surely theres a less repetitive way to add them than this though

portfiend avatar Jul 16 '24 16:07 portfiend

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 16 '24 21:07 github-actions[bot]

Is this meant to be drafted, still?

Timemaster99 avatar Jul 21 '24 19:07 Timemaster99

Is this meant to be drafted, still?

i believe so, this PR creates redundancy with a bunch of other loadouts. a lot of loadouts have scarfs in the job-based neck selection AND in the scarfs loadout now and ive been trying to think on how to go about it

portfiend avatar Jul 21 '24 19:07 portfiend

I really love scarves, and this is awesome.

surely theres a less repetitive way to add them than this though

there isn't, loadouts is specifically designed to stop multi-loadout items

DangerRevolution avatar Jul 24 '24 07:07 DangerRevolution

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 25 '24 01:07 github-actions[bot]

Until we have some sort of universal loadout in addition to role-specific loadouts, I am generally in favor of expanding the selection. Some of these lists are going to get really long though, and giving every single role access to the wide variety of passenger drip in this game is going to be a tedious nightmare to write and review.

Also, let prisoners and gladiators have scarves! Is there any mechanical reason not to let them have such things?

Samsterious avatar Sep 05 '24 11:09 Samsterious

Until we have some sort of universal loadout in addition to role-specific loadouts, I am generally in favor of expanding the selection. Some of these lists are going to get really long though, and giving every single role access to the wide variety of passenger drip in this game is going to be a tedious nightmare to write and review.

I'm pretty sure the way Frontier got past the restriction of giving everyone passenger drip was just getting rid of the job restriction in some sense

ghost avatar Sep 05 '24 21:09 ghost

Is this still being worked on, @portfiend?

TadJohnson00 avatar Sep 20 '24 12:09 TadJohnson00

Is this still being worked on, @portfiend?

nope

portfiend avatar Sep 20 '24 17:09 portfiend