Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Administrative Assistant, a new RP / Support centric "command" role

Open noctyrnal opened this issue 1 year ago • 20 comments

About the PR

Adds the Administrative Assistant role to all stations, acting as both a secretary for command and as a worker on the bridge, answering faxes , grabbing coffees for command members and so on. Intended to support command members in more menial tasks, and to provide unique RP circumstances.

Why / Balance

Makes command's life a bit easier to have a person dedicated to helping them do the small things

Technical details

None

Media

f77bc14897d700be8c36fde6fb72c6af

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

  • add: Added the Administrative Assistant Role! Assist command in their day-to-day activities, grab the captain a coffee, answer faxes in the bridge!

noctyrnal avatar May 15 '24 22:05 noctyrnal

This PR contains new or changed maps:

  • arena.yml
  • asterisk.yml
  • edge.yml
  • hammurabi.yml
  • hive.yml
  • lighthouse.yml
  • pebble.yml
  • shoukou.yml
  • submarine.yml
  • tortuga.yml

Maps are being rendered. This comment will be updated if rendering them is done. 05/15/24 22:46

deltav-mapserver[bot] avatar May 15 '24 22:05 deltav-mapserver[bot]

RSI Diff Bot; head commit 2dfd51cc72b8f31864d4d13b28372bfc099425ad merging into 48397c83a22058398d9a1d76f35a32edacdc9ab5 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/admin_assistant.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/admin_assistant.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added
Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State Old New Status
AdminAssistant Added
Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State Old New Status
pda-admin-assistant Added
Resources/Textures/DeltaV/Objects/Misc/id_cards.rsi

State Old New Status
idadminassistant Added
Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State Old New Status
stamp-admin-assistant Added
Resources/Textures/Markers/jobs.rsi

State Old New Status
adminassistant Added
Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
paper_stamp-admin-assistant Added
Edit: diff updated after 2dfd51cc72b8f31864d4d13b28372bfc099425ad

github-actions[bot] avatar May 15 '24 22:05 github-actions[bot]

Why does this remove courier localisation?

Probably me misreading one of the changes in master and assuming I accidentally deleted something, I'll go undo that now

You shouldn't be editing maps in the same pr that introduces something, mappers should do that on their own, or if they're unavailable, it should be a seperate pr.

Noted

noctyrnal avatar May 15 '24 22:05 noctyrnal

I see more problems, but I'll do a bigger review tomorrow

Axionyxx avatar May 15 '24 22:05 Axionyxx

Localized entities are not a requirement and make editing more difficult. It should only be reserved for non English codebases.

Axionyxx avatar May 15 '24 23:05 Axionyxx

Localized entities are not a requirement and make editing more difficult. It should only be reserved for non English codebases.

would be nice for some of our downstreams that aren't English :)

DangerRevolution avatar May 15 '24 23:05 DangerRevolution

By name, this is an assistant role, similar to technical assistant, research assistant, security cadet and medical intern. New players will see this and think of it as a decent role to get them used to the pressures of command before entering a position of responsibility. That's why I motion to remove the command time requirement and whitelist. For the whitelist, I believe the purpose of that system is to keep the most influential roles to a higher standard. By itself, this role has no influence and depends on assignments from command to enact any authority (as you will not see anyone respecting the will of someone with "assistant" in their job name). As for the command time, it's unnecessary to require the role with the lowest authority in command to be in the upper echelon of experience for command roles, especially because of how attractive this role is to newer players looking to learn command. I understand that the requirements are likely a result of the accesses granted to the role. I agree with Danger that these should be limited. Chief Engineer could benefit from AA to repair station-threatening breaches, but they are still not afforded that much power. Command access is all that's required for this role to operate normally, and since that access gives them permission to call the shuttle and make announcements, the 30 hour overall requirement is equitable. Command requirements already average ~30 hours playtime, so this is definitely enough to prevent raiders and uncommitted players. Aside from that, I think a role to help transition players into command is a great addition. It will help new players attach to a command member of choice and learn from them, while also giving some nice interactions and roleplay for command members themselves. Great job on this PR

Timemaster99 avatar May 16 '24 00:05 Timemaster99

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 18 '24 12:05 github-actions[bot]

Still need to figure out how to get the map file changes undone fully, but review stuff should be done for now atleast.

noctyrnal avatar May 28 '24 19:05 noctyrnal

Still need to figure out how to get the map file changes undone fully, but review stuff should be done for now atleast.

git checkout master FILEPATH to revert the specified FILEPATH to the version in master. Then commit the changes

Timemaster99 avatar May 28 '24 19:05 Timemaster99

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 01 '24 21:06 github-actions[bot]

I plan on renaming this to Administrative Secretary to further get the point across that this is a support command role and not a command role designed for learning the aspects of command. I'll do this once I have everything all done as per the final review.

noctyrnal avatar Jun 03 '24 14:06 noctyrnal

and to localise some of the new entities

You have already been informed we don't do this several times. If you continue to give our contributors bad advice like this, you may be banned from the repository.

Axionyxx avatar Jun 03 '24 17:06 Axionyxx

If you continue to give our contributors bad advice like this,

image

DangerRevolution avatar Jun 03 '24 19:06 DangerRevolution

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 07 '24 13:06 github-actions[bot]

Should be all ready for a review now, merged to master and fixed the conflicts

noctyrnal avatar Jun 11 '24 14:06 noctyrnal

we're so back secretary bros

noctyrnal avatar Jun 12 '24 17:06 noctyrnal

This would probably be the command role I would play the most. Head of Paperwork, basically. I love bureaucracy.

sword-of-stabbing avatar Jun 12 '24 21:06 sword-of-stabbing

This would probably be the command role I would play the most. Head of Paperwork, basically. I love bureaucracy.

HoP in shambles

Timemaster99 avatar Jun 12 '24 23:06 Timemaster99

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 14 '24 12:06 github-actions[bot]

Hey @noctyrnal do you mind if i yoink this and finish it?

Radezolid avatar Dec 23 '24 19:12 Radezolid

Hey @noctyrnal do you mind if i yoink this and finish it?

Go wild.

noctyrnal avatar Dec 24 '24 02:12 noctyrnal

Thanks!

Radezolid avatar Dec 24 '24 23:12 Radezolid