Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Allow vulps to wag

Open pissdemon opened this issue 1 year ago • 4 comments

About the PR

Vulps can now toggle wagging if their tail supports it. Corgi and dalmatian tails also get a non-wagging variant courtesy of CD.

Why / Balance

People have wanted this for a while, I guess?

Known issues

  • Button is still displayed when the tail does not have a wagging animation (which a few do, I think it's: fennec, fox2, fox3, fluffy, otie, long). Nothing will happen if you click on it. Maybe a bit confusing.
  • Will log a warning to the server console when someone tries to wag with a tail that doesn't have a wagging animation.

Technical details

Basically ported from https://github.com/cosmatic-drift-14/cosmatic-drift/pull/214. Uses the lizard tail wagging system. Old "wag" variants are removed and replaced with hidden (in character setup) "animated" variants.

Media

It's exactly the same as the lizard tail wagging.

Breaking changes

Database needs a migration to be run on it that fixes the markings field on profiles, since this PR removes the "wagging" variants we used to have and people have those selected. They need to be replaced with the non-wagging variant in the DB, just look at #rebase.

Changelog :cl:

  • tweak: Vulpkanins can now toggle wagging their tails. (Some tails cannot wag yet, please contribute sprites for them!)

pissdemon avatar Apr 29 '24 18:04 pissdemon

RSI Diff Bot; head commit d6522dc916d6f9e6d603c70687678cf25aa5a370 merging into 511685e7b66d267ad1edcf199c5aa9f88de54de2 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/Vulpkanin/tail_markings.rsi

State Old New Status
corgi Added
dalmatian Added
tail-wag-icon Added
Edit: diff updated after d6522dc916d6f9e6d603c70687678cf25aa5a370

github-actions[bot] avatar Apr 29 '24 18:04 github-actions[bot]

YAML linter fail not related to this PR but railguns, filed as #1153

pissdemon avatar Apr 29 '24 18:04 pissdemon

Will probably make the migration part handled with an EF migration later

pissdemon avatar Apr 29 '24 20:04 pissdemon

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 27 '24 17:05 github-actions[bot]

Cool. More non-intrusive roleplay mechanics that give people just a little more flexibility? Hell yeah. CD is a treasure trove of uninvasive HRP features that work just fine in MRP, and I am super down to see more PRs mirroring their successes.

Samsterious avatar Sep 05 '24 10:09 Samsterious

Closing this in favor of a port of this from EE or something.

pissdemon avatar Sep 07 '24 00:09 pissdemon