Delta-v icon indicating copy to clipboard operation
Delta-v copied to clipboard

Pretty Disposals

Open rosieposieeee opened this issue 1 year ago • 16 comments

About the PR

Brings back the old disposal sprites, and adds a 'space' variant that warns you that it goes to space, for the maps that have spaced disposals (Hive's perma, Sub's everything.) (Otherwise, the space one is no different than a normal one.)

If anyone has a better idea than a generic yellow warning triangle I'll sprite it.

QR7aqBY9Ru

Content Client_zmlLtlqNMP

image

Why / Balance

The new sprites were ugly, and I had to make a new RSI for the space one anyway (or touch the upstream RSI, but I didn't want to.)

Media

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog :cl:

  • tweak: Added Space Disposals with a warning sign on them, and made disposals pretty again.

rosieposieeee avatar Mar 26 '24 15:03 rosieposieeee

RSI Diff Bot; head commit 6694273a13684c05f80e25513c43020b1de89358 merging into 9b6fbd24f291d5992124fc3ec4c9d6109fc1f183 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Piping/disposal.rsi

State Old New Status
condisposal Added
conmailing Added
conspace Added
disposal-charging Added
disposal-flush Added
disposal Added
dispover-charge Added
dispover-full Added
dispover-handle Added
dispover-ready Added
mailing-charging Added
mailing-flush Added
mailing Added
mailover-handle Added
space Added
Edit: diff updated after 6694273a13684c05f80e25513c43020b1de89358

github-actions[bot] avatar Mar 26 '24 15:03 github-actions[bot]

bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line

DangerRevolution avatar Mar 26 '24 15:03 DangerRevolution

are all the pipes & unused intake sprites necessary in the new folder?

DangerRevolution avatar Mar 26 '24 15:03 DangerRevolution

bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line

space disposals relies on it, otherwise i would have to touch upstream files

are all the pipes & unused intake sprites necessary in the new folder?

probably not, ill cut them out

rosieposieeee avatar Mar 26 '24 15:03 rosieposieeee

bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line

space disposals relies on it, otherwise i would have to touch upstream files

you can PR the old sprites & PR the space sprites; and ask for the old sprites to be merged first so it works

DangerRevolution avatar Mar 26 '24 15:03 DangerRevolution

bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line

space disposals relies on it, otherwise i would have to touch upstream files

you can PR the old sprites & PR the space sprites; and ask for the old sprites to be merged first so it works

yeah but if it was undone, you'd have to undo both anyway

rosieposieeee avatar Mar 26 '24 15:03 rosieposieeee

The question is, should I warn the prisoners in Hive....

After all, there is an observation window set up so other prisoners can point and laugh 😄

IamVelcroboy avatar Mar 27 '24 16:03 IamVelcroboy

amazing, god bless my beloved old chutes

UnicornOnLSD avatar Mar 28 '24 09:03 UnicornOnLSD

lol

rosieposieeee avatar Mar 28 '24 19:03 rosieposieeee

Looks fine to me. Just waiting to see if any other maintainers have thoughts...?

IamVelcroboy avatar Apr 04 '24 17:04 IamVelcroboy

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 09 '24 07:04 github-actions[bot]

Fix tests then this looks good.

DEATHB4DEFEAT avatar Apr 11 '24 05:04 DEATHB4DEFEAT

Any update? Tests are still failing.

Colin-Tel avatar May 26 '24 15:05 Colin-Tel

laziness ops wins again

rosieposieeee avatar May 27 '24 03:05 rosieposieeee

👻

IamVelcroboy avatar Jul 20 '24 18:07 IamVelcroboy

Should revive this

Timemaster99 avatar Jul 20 '24 18:07 Timemaster99

As the oldest open PR in the repo currently (the actual oldest one is Danger's Angle draft PR,) what's the consensus on if we want old disposals? I'm so used to the new sprite that I kinda forgot how nice this one looked.

ghost avatar Sep 02 '24 11:09 ghost

I would like old disposals back, I think this is neat.

TadJohnson00 avatar Sep 05 '24 05:09 TadJohnson00