Pretty Disposals
About the PR
Brings back the old disposal sprites, and adds a 'space' variant that warns you that it goes to space, for the maps that have spaced disposals (Hive's perma, Sub's everything.) (Otherwise, the space one is no different than a normal one.)
If anyone has a better idea than a generic yellow warning triangle I'll sprite it.
Why / Balance
The new sprites were ugly, and I had to make a new RSI for the space one anyway (or touch the upstream RSI, but I didn't want to.)
Media
- [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Changelog :cl:
- tweak: Added Space Disposals with a warning sign on them, and made disposals pretty again.
RSI Diff Bot; head commit 6694273a13684c05f80e25513c43020b1de89358 merging into 9b6fbd24f291d5992124fc3ec4c9d6109fc1f183 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Resources/Textures/DeltaV/Structures/Piping/disposal.rsi
| State | Old | New | Status |
|---|---|---|---|
| condisposal | ![]() |
Added | |
| conmailing | ![]() |
Added | |
| conspace | ![]() |
Added | |
| disposal-charging | ![]() |
Added | |
| disposal-flush | ![]() |
Added | |
| disposal | ![]() |
Added | |
| dispover-charge | ![]() |
Added | |
| dispover-full | ![]() |
Added | |
| dispover-handle | ![]() |
Added | |
| dispover-ready | ![]() |
Added | |
| mailing-charging | ![]() |
Added | |
| mailing-flush | ![]() |
Added | |
| mailing | ![]() |
Added | |
| mailover-handle | ![]() |
Added | |
| space | ![]() |
Added |
bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line
are all the pipes & unused intake sprites necessary in the new folder?
bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line
space disposals relies on it, otherwise i would have to touch upstream files
are all the pipes & unused intake sprites necessary in the new folder?
probably not, ill cut them out
bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line
space disposals relies on it, otherwise i would have to touch upstream files
you can PR the old sprites & PR the space sprites; and ask for the old sprites to be merged first so it works
bringing back old sprite should be it's own PR for easy reversal should it be wanted/needed down the line
space disposals relies on it, otherwise i would have to touch upstream files
you can PR the old sprites & PR the space sprites; and ask for the old sprites to be merged first so it works
yeah but if it was undone, you'd have to undo both anyway
The question is, should I warn the prisoners in Hive....
After all, there is an observation window set up so other prisoners can point and laugh 😄
amazing, god bless my beloved old chutes
lol
Looks fine to me. Just waiting to see if any other maintainers have thoughts...?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Fix tests then this looks good.
Any update? Tests are still failing.
laziness ops wins again
👻
Should revive this
As the oldest open PR in the repo currently (the actual oldest one is Danger's Angle draft PR,) what's the consensus on if we want old disposals? I'm so used to the new sprite that I kinda forgot how nice this one looked.
I would like old disposals back, I think this is neat.














