react-media-recorder icon indicating copy to clipboard operation
react-media-recorder copied to clipboard

added audio recorder - onStop doesn't pick up

Open urosran opened this issue 4 years ago • 2 comments

urosran avatar Jul 17 '20 03:07 urosran

Hello!

Thank @0x006F you for this library and @urosran for collaborating in it 👏

I know it's not my business, but a couple of things makes me think that this PR should not be merged in its current state:

  • It adds a polyfill that, and IMO it should be the library user who decides if include it or not. Maybe I know all my devices can record, or maybe I was want to detect it and skip recording. @urosran Is it possible to implement this functionality without the polyfill?
  • There are some console.logs and alert calls that can be annoying for the end user

My two cents.

danigb avatar Oct 20 '20 21:10 danigb

Besides the console.logs and alerts (we can clean up at any time), I guess @danigb has a valid point in this case. As we discussed in #19 , even though this polyfill kinda work, it doesn't support video capturing yet. So, we're losing one of our key features in here.

I sincerely apologize for this delayed replies. I'm having numerous meetings / plannings at my full-time + work. Sorry!

DeltaCircuit avatar Oct 22 '20 08:10 DeltaCircuit