mercury
mercury copied to clipboard
Fontawesome 5
[CHG] Upgraded to Fontawesome 5 [ADD] Vue-Fontawesome for SVG icons (more performance in standalone apps) [CHG] Upgraded bulma 0.7.0 -> 0.7.1
Hi there, I'm not accepting this PR yet, it need some more work :
- [x] When creating an account :
- [x] button " create an account " lack is icon
- [x] currency's selection is not displaying the right currency icon
- [ ] On the accounts detail or when changing operation type, operation type other than credit card is not displaying
- [x] Same thing on the state of the operation
- [ ] On the recurring pane, in the queue of operations, the type is not displayed (just a circle)
- [ ]
filters.vue
:- [x] the time span selector icon is missing
- [ ] Filtering on state is not working (to have full backward compatibility, the operation should save old fashion font-awesome 4 as state, and the filter should look for those selector)
- [x] Reports lack their icon (top-left)
There may be some version incompatibility with Bulma, as some visuals look weird (unsaved icon is huuuuge and icon-only buttons are wider than high instead of square)
- [x] What do you mean by
filters.vue
? This file does not exist. - [x] I did not find any * create an account* buttons without an icon.
⚠️ We must create database migration for the icons. I don't know why but storing the FontAwesome icon name as the state of an operation is pretty bad IMHO.
This must be migrated to a new state. For overview purposes, I highly recommend doing this in a sperate PR but as a blocker. No productive release until this migration is done (otherwise may make old databases unusable).
Yep sorry for the mistake, I was talking about src/renderer/components/MainPane/accountsDetails/filterBar.vue
Concerning the button without icon, it is ok now. Maybe some misfunctionning on my side (on icon maybe had some trouble loading ¯_(ツ)_/¯)
I strongly agree with the fact of changing the way the state is stored, it is wobbly since the first release. However I don't know how to run the migration script. Ask the user to commit the action ? Look for database integrity on each boot and run if compromised ?
For the migration please refer to #17