Dekadinious
Dekadinious
@jonathanbossenger That's great, and I would love that. But how do I test a specific PR? 😅
@jonathanbossenger Thank you for the guidance! I can confirm that it works, and I also tested https://github.com/valeryan/vscode-phpsab/pull/139 and can confirm that both spaces and special characters no longer trigger the...
Seems this was not included in 0.0.20 or regressed?
@mikejolley Thank you for being quick on the trigger here. I'll see if I can conjure up a minimal test case tomorrow 👍
Here is a minimal test case using an install with only Storefront 4.6.1 and WooCommerce 9.9.4 active. The first step is to create an uppercase coupon. I created TESTCOUPON as...
@mikejolley My initial thought here is: Will WooCommerce stop users from adding "TESTCOUPON" and then after add "testcoupon" in the admin? Because if yes, are they not conceptually the same...
@mikejolley I understand - but would it not be more natural that they get lowercased before getting returned in the array? So there is only one casing to care about?...
@mikejolley Got it!