DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

Added type definitions for pdf417

Open knee-cola opened this issue 1 month ago • 3 comments

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [✔️ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [✔️] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ✔️] Create it with dts-gen --dt, not by basing it on an existing project.
  • [✔️] Represents shape of module/library correctly
  • [✔️] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.

knee-cola avatar Nov 22 '25 08:11 knee-cola

@knee-cola Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 26 days — it is considered nearly abandoned!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74125,
  "author": "knee-cola",
  "headCommitOid": "29d2a30bb228865a56c1bc60a3e670a1a624c2bd",
  "mergeBaseOid": "03bca40577f214e676f262ee4e4ca1a9edf82a45",
  "lastPushDate": "2025-11-22T08:50:15.000Z",
  "lastActivityDate": "2025-11-22T08:50:15.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "pdf417",
      "kind": "add",
      "files": [
        {
          "path": "types/pdf417/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/pdf417/pdf417-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/pdf417/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/pdf417/tslint.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [],
      "addedOwners": [
        "kneecola"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3566177234,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/29d2a30bb228865a56c1bc60a3e670a1a624c2bd/checks?check_suite_id=50537752989"
}

typescript-bot avatar Nov 22 '25 08:11 typescript-bot

🔔 @knee-cola — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

typescript-bot avatar Nov 22 '25 08:11 typescript-bot

@knee-cola The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Nov 22 '25 08:11 typescript-bot

@knee-cola I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Dec 22nd (in a week) if the issues aren't addressed.

typescript-bot avatar Dec 15 '25 13:12 typescript-bot