DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

add anonrig to types/node owners

Open anonrig opened this issue 6 months ago • 2 comments

Please fill in this template.


I'm a @nodejs technical steering committee member interested in contributing to types/node and fixing the gap between the actual implementation and types/node.

anonrig avatar Jun 17 '25 15:06 anonrig

@anonrig Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

  • nodeon npm, on unpkg
    • owner-approval: @mcollina, @Renegade334
    • 1 added owner: ✎@anonrig

@anonrig: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73045,
  "author": "anonrig",
  "headCommitOid": "98271be80bd8eb96c00431eb28ae049235319ef4",
  "mergeBaseOid": "bcf35f7149037348db87832d3b0a3e3fed0543a0",
  "lastPushDate": "2025-06-17T15:54:03.000Z",
  "lastActivityDate": "2025-06-27T18:57:06.000Z",
  "maintainerBlessed": "Waiting for Author to Merge (Blessed)",
  "mergeOfferDate": "2025-06-27T18:52:34.000Z",
  "mergeRequestDate": "2025-06-27T18:57:06.000Z",
  "mergeRequestUser": "anonrig",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky",
        "Renegade334"
      ],
      "addedOwners": [
        "anonrig"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "panva",
      "date": "2025-06-19T08:10:03.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "mcollina",
      "date": "2025-06-17T16:54:38.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "ljharb",
      "date": "2025-06-17T16:06:47.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "Renegade334",
      "date": "2025-06-17T15:54:30.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2980927114,
  "ciResult": "pass"
}

typescript-bot avatar Jun 17 '25 15:06 typescript-bot

@peterblazejewicz @eps1lon can you review this?

anonrig avatar Jun 18 '25 16:06 anonrig

:hourglass_flowing_sand: Hi @anonrig,

It's been a few days since this PR was approved by panva, mcollina, ljharb, Renegade334 and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package that verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

typescript-bot avatar Jun 21 '25 18:06 typescript-bot

@anonrig: Everything looks good here. I am ready to merge this PR (at 98271be) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@Microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @NodeJS, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @Renegade334: you can do this too.)

typescript-bot avatar Jun 27 '25 18:06 typescript-bot

Ready to merge

anonrig avatar Jun 27 '25 18:06 anonrig