DefinitelyTyped
Add peerDependencies blurb to README
Goes with https://github.com/microsoft/DefinitelyTyped-tools/pull/1072 / https://github.com/microsoft/DefinitelyTyped-tools/issues/433
@jakebailey Thank you for submitting this PR!
This is a live comment that I will keep updated.
This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?
0 packages in this PR (and infra files)
- Infra files
Code Reviews
There aren't any other owners of this package, so a DT maintainer will review it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ A DT maintainer needs to approve changes that affect DT infrastructure (
README.md)
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Inactive
This PR has been inactive for 5 days.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 70851,
"author": "jakebailey",
"headCommitOid": "474af743fbcea47531a69e7e4223024ebbbc020e",
"mergeBaseOid": "454deafa05c6a42cf7f18cda2074ca04afad4372",
"lastPushDate": "2024-10-09T23:08:30.000Z",
"lastActivityDate": "2024-10-21T23:35:38.000Z",
"mergeOfferDate": "2024-10-16T13:43:13.000Z",
"mergeRequestDate": "2024-10-21T23:35:38.000Z",
"mergeRequestUser": "jakebailey",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "README.md",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-10-16T13:42:36.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "andrewbranch",
"date": "2024-10-14T23:12:18.000Z",
"abbrOid": "a1deff9"
}
],
"mainBotCommentID": 2403589896,
"ciResult": "pass"
}
🔔 @jakebailey — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)
@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@sandersn, @andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@jakebailey: Everything looks good here. I am ready to merge this PR (at 474af74) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart: