VedariusARussell
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
Select one of these and delete the others:
If adding a new definition:
- [x] The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declaration - [x] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
- [x] Create it with
dts-gen --dt, not by basing it on an existing project. - [x] Represents shape of module/library correctly
- [x]
tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <
> - [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.
If removing a declaration:
- [x] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
- [x] Delete the package's directory.
- [x] Add it to
notNeededPackages.json.
@YoutacRandS-VA Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.
This is a live comment that I will keep updated.
This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?
10 packages in this PR (and infra files)
-
aws-synthetics-puppeteer— on npm, on unpkg -
dingtalk-robot-sender— on npm, on unpkg -
electron-positioner— on npm, on unpkg -
gulp-javascript-obfuscator— on npm, on unpkg -
hexo-fs— on npm, on unpkg -
knex-db-manager— on npm, on unpkg -
lesgo— on npm, on unpkg -
merge-img— on npm, on unpkg -
postcss-use— on npm, on unpkg -
schwifty— on npm, on unpkg - Infra files
Code Reviews
Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.
You can test the changes of this PR in the Playground.
Status
- ❌ No merge conflicts
- ❓ Continuous integration tests have gone missing
- 🕐 A DT maintainer needs to approve changes that affect DT infrastructure (
.github/dependabot.yml,.github/workflows/nextjs.yml,.github/workflows/terraform.yml,LICENSE)
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.
Inactive
This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 70602,
"author": "YoutacRandS-VA",
"headCommitOid": "8b9a365d9d5cb5843196d91d89fc5fe16a84efcb",
"mergeBaseOid": "d1c172bdcfd4508405f4b233e11ccd7d8743f763",
"lastPushDate": "2024-09-19T04:09:06.000Z",
"lastActivityDate": "2024-10-20T15:28:43.000Z",
"hasMergeConflict": true,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": ".github/dependabot.yml",
"kind": "infrastructure"
},
{
"path": ".github/workflows/nextjs.yml",
"kind": "infrastructure"
},
{
"path": ".github/workflows/terraform.yml",
"kind": "infrastructure"
},
{
"path": "LICENSE",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "aws-synthetics-puppeteer",
"kind": "edit",
"files": [
{
"path": "types/aws-synthetics-puppeteer/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Tantalon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "dingtalk-robot-sender",
"kind": "edit",
"files": [
{
"path": "types/dingtalk-robot-sender/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"bangbang93"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "electron-positioner",
"kind": "edit",
"files": [
{
"path": "types/electron-positioner/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ktmouk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gulp-javascript-obfuscator",
"kind": "edit",
"files": [
{
"path": "types/gulp-javascript-obfuscator/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"MysteryBlokHed"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "hexo-fs",
"kind": "edit",
"files": [
{
"path": "types/hexo-fs/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"segayuu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "knex-db-manager",
"kind": "edit",
"files": [
{
"path": "types/knex-db-manager/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dimonnwc3",
"nicu-chiciuc"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "lesgo",
"kind": "edit",
"files": [
{
"path": "types/lesgo/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"xxlxx"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "merge-img",
"kind": "edit",
"files": [
{
"path": "types/merge-img/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "postcss-use",
"kind": "edit",
"files": [
{
"path": "types/postcss-use/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"MysteryBlokHed"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "schwifty",
"kind": "edit",
"files": [
{
"path": "types/schwifty/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ozum",
"timcosta"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "MysteryBlokHed",
"date": "2024-10-13T20:28:25.000Z",
"abbrOid": "e71bba7"
},
{
"type": "stale",
"reviewer": "Tantalon",
"date": "2024-09-19T04:40:31.000Z",
"abbrOid": "92da3cf"
}
],
"mainBotCommentID": 2359936074,
"ciResult": "missing"
}
🔔 @Tantalon @bangbang93 @ktmouk @MysteryBlokHed @segayuu @dimonnwc3 @nicu-chiciuc @xxlxx @peterblazejewicz @ozum @timcosta — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
@YoutacRandS-VA Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
@YoutacRandS-VA Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
@YoutacRandS-VA Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
@YoutacRandS-VA I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Oct 19th (in a week) if the issues aren't addressed.
@YoutacRandS-VA Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
@YoutacRandS-VA Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
This PR appears to be nothing more than a bot or malicious user based on the license modification and variety of other files being added or modified.
@YoutacRandS-VA I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Nov 19th (in a week) if the issues aren't addressed.
@YoutacRandS-VA To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!