DefinitelyTyped
Fix of "The file '@types/favico.js/index.d.ts' is not a module.ts(2306)"
Error fixed adding declare module "favico.js" line.
The file '~/app/node_modules/@types/favico.js/index.d.ts' is not a module.ts(2306) favico.js - 0.3.10 Node - v20.15.0 NPM - 10.8.1
@MrHoss Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.
This is a live comment that I will keep updated.
1 package in this PR
Code Reviews
This PR can be merged once it's reviewed by a DT maintainer.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ❌ Continuous integration tests have failed
- 🕐 Only a DT maintainer can approve changes without tests
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.
Inactive
This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 69928,
"author": "MrHoss",
"headCommitOid": "3b07076a59f90f3f3e8530a4f6491759f01e9911",
"mergeBaseOid": "a75bdae278c1b80f762edc34b0b82049f2aa506d",
"lastPushDate": "2024-06-28T00:15:24.000Z",
"lastActivityDate": "2024-07-19T16:02:10.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "favico.js",
"kind": "edit",
"files": [
{
"path": "types/favico.js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"drowse314-dev-ymat"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2195863577,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3b07076a59f90f3f3e8530a4f6491759f01e9911/checks?check_suite_id=25408559749"
}
Hey @MrHoss,
:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.
This can potentially save days of time for you!
🔔 @drowse314-dev-ymat — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
@MrHoss The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.
@MrHoss I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Aug 18th (in a week) if the issues aren't addressed.
@MrHoss To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!