[purify] Add package purify
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
Select one of these and delete the others:
If adding a new definition:
- [x] The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declaration - [x] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
- [x] Create it with
dts-gen --dt, not by basing it on an existing project. - [x] Represents shape of module/library correctly
- [x]
tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.
@ffflorian Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Only a DT maintainer can approve changes when there are new packages added
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 69629,
"author": "ffflorian",
"headCommitOid": "88829ac143c888cec9e4fd112ceed34335f76e64",
"mergeBaseOid": "425f0ebe145ac9337b0bcbd1084a548d729b4963",
"lastPushDate": "2024-05-17T11:58:58.000Z",
"lastActivityDate": "2024-05-18T04:34:25.000Z",
"mergeOfferDate": "2024-05-17T20:07:15.000Z",
"mergeRequestDate": "2024-05-18T04:34:25.000Z",
"mergeRequestUser": "ffflorian",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "purify",
"kind": "add",
"files": [
{
"path": "types/purify/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/purify/index.d.ts",
"kind": "definition"
},
{
"path": "types/purify/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/purify/purify-tests.ts",
"kind": "test"
},
{
"path": "types/purify/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"ffflorian"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-05-17T20:06:39.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2117441455,
"ciResult": "pass"
}
🔔 @ffflorian — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)
@ffflorian The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@ffflorian The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@ffflorian: Everything looks good here. I am ready to merge this PR (at 88829ac) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
Ready to merge