DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

[@types/selectize] Add missing `silent` parameter

Open codershiba opened this issue 1 year ago • 6 comments

Fixes #69495 Fixes #69428

Please fill in this template.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes:
  • https://github.com/selectize/selectize.js/blob/master/dist/js/selectize.js#L1985
  • https://github.com/selectize/selectize.js/blob/master/dist/js/selectize.js#L2228
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

codershiba avatar May 02 '24 11:05 codershiba

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 20 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69499,
  "author": "codershiba",
  "headCommitOid": "ee27f013c03ff0ec89b7bd24c26f55a3928e71f0",
  "mergeBaseOid": "11ab9a78ca6b1bf454b895aa874ca3f4b203b198",
  "lastPushDate": "2024-05-02T11:45:23.000Z",
  "lastActivityDate": "2024-05-16T16:44:46.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "selectize",
      "kind": "edit",
      "files": [
        {
          "path": "types/selectize/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adidahiya",
        "naBausch"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sandersn",
      "date": "2024-05-16T16:44:46.000Z"
    }
  ],
  "mainBotCommentID": 2090301338,
  "ciResult": "pass"
}

typescript-bot avatar May 02 '24 11:05 typescript-bot

Hey @codershiba,

:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

typescript-bot avatar May 02 '24 11:05 typescript-bot

🔔 @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar May 02 '24 11:05 typescript-bot

The DT package is at 0.12, but the upstream package is at 0.15. When was this parameter actually added?

jakebailey avatar May 06 '24 16:05 jakebailey

Re-ping @adidahiya, @naBausch:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot avatar May 13 '24 13:05 typescript-bot

@codershiba One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot avatar May 16 '24 16:05 typescript-bot

There was an error that prevented me from properly processing this PR:

PR author does not exist

typescript-bot avatar Jun 06 '24 15:06 typescript-bot