DefinitelyTyped
DefinitelyTyped copied to clipboard
DefinitelyTyped
Dsb/oracle 6.3.0 update
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [ ] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
Select one of these and delete the others:
If adding a new definition:
- [ ] The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declaration - [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
- [ ] Create it with
dts-gen --dt, not by basing it on an existing project. - [ ] Represents shape of module/library correctly
- [ ]
tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.
If changing an existing definition:
- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <
> - [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.
If removing a declaration:
- [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
- [ ] Delete the package's directory.
- [ ] Add it to
notNeededPackages.json.
@dannyb648 Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
This PR can be merged once it's reviewed by a DT maintainer.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Only a DT maintainer can approve changes without tests
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68742,
"author": "dannyb648",
"headCommitOid": "875c02b064036c05624aee5ea7c71f96482e3a24",
"mergeBaseOid": "02b9f04919f8b529f6472b7b183ebae214a75f23",
"lastPushDate": "2024-02-23T20:24:43.000Z",
"lastActivityDate": "2024-03-15T13:42:50.000Z",
"mergeOfferDate": "2024-03-15T12:52:57.000Z",
"mergeRequestDate": "2024-03-15T13:42:50.000Z",
"mergeRequestUser": "dannyb648",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "oracledb",
"kind": "edit",
"files": [
{
"path": "types/oracledb/index.d.ts",
"kind": "definition"
},
{
"path": "types/oracledb/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"connorjayfitzgerald",
"dannyb648",
"jacobwheale"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-03-15T12:52:16.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "BekYahia",
"date": "2024-03-14T17:09:16.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1961943730,
"ciResult": "pass"
}
Hey @dannyb648,
:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.
This can potentially save days of time for you!
🔔 @connorjayfitzgerald @jacobwheale — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
Formatting
The following files are not formatted:
- types/oracledb/index.d.ts
Consider running pnpm dprint fmt on these files to make review easier.
Generated by :no_entry_sign: dangerJS against 875c02b064036c05624aee5ea7c71f96482e3a24
@dannyb648 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
@dannyb648 The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
It has been more than two weeks and this PR still has no reviews.
I'll bump it to the DT maintainer queue. Thank you for your patience, @dannyb648.
(Ping @connorjayfitzgerald, @jacobwheale.)
@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@dannyb648 The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@dannyb648 The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@dannyb648 The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@BekYahia, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@dannyb648: Everything looks good here. I am ready to merge this PR (at 875c02b) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@connorjayfitzgerald, @jacobwheale: you can do this too.)