[@types/pleasanter-web-script] fix AttachmentsHash data type
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
Select one of these and delete the others:
If adding a new definition:
- [ ] The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declaration - [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
- [ ] Create it with
dts-gen --dt, not by basing it on an existing project. - [ ] Represents shape of module/library correctly
- [ ]
tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <
> - [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.
If removing a declaration:
- [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
- [ ] Delete the package's directory.
- [ ] Add it to
notNeededPackages.json.
@yamada28go Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners, DT maintainers or others
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68703,
"author": "yamada28go",
"headCommitOid": "b466f5a0099f2651e6231e469d424e4b805b49bf",
"mergeBaseOid": "d3d8481d7a922f17654c88927ea7c19655d94764",
"lastPushDate": "2024-02-20T13:58:22.000Z",
"lastActivityDate": "2024-03-12T13:25:35.000Z",
"mergeOfferDate": "2024-03-11T20:43:44.000Z",
"mergeRequestDate": "2024-03-12T13:25:35.000Z",
"mergeRequestUser": "yamada28go",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "pleasanter-web-script",
"kind": "edit",
"files": [
{
"path": "types/pleasanter-web-script/index.d.ts",
"kind": "definition"
},
{
"path": "types/pleasanter-web-script/pleasanter-web-script-tests.ts",
"kind": "test"
}
],
"owners": [
"yamada28go"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-03-11T20:38:53.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Anonymous4078",
"date": "2024-02-23T17:34:28.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1954273550,
"ciResult": "pass"
}
🔔 @yamada28go — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)
I made a mistake in the type definition, so I fixed it.
The relevant document is here. https://pleasanter.org/manual/api-record-get
thank you
@dt-bot merge this
@peterblazejewicz
I'm sorry to bother you while you're busy. Could you please look into why it's not being merged at all?
Ready to merge
Sorry for the obvious fail of automation here :)
Thank you for merging .