DefinitelyTyped
DefinitelyTyped copied to clipboard
feat: add Instafeed.js types
Please fill in this template.
-
[x] Use a meaningful title for the pull request. Include the name of the package modified.
-
[ ] Test the change in your own code. (Compile and run.)
-
[x] Add or edit tests to reflect the change.
-
[x] Follow the advice from the readme.
-
[x] Avoid common mistakes.
-
[x] The package does not already provide its own types, or cannot have its
.d.ts
files generated via--declaration
-
[x] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
-
[x] Create it with
dts-gen --dt
, not by basing it on an existing project. -
[x] Represents shape of module/library correctly
-
[x]
tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.
@IncognitaDev Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Only a DT maintainer can approve changes when there are new packages added
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68696,
"author": "IncognitaDev",
"headCommitOid": "15452f32c1ceff9bb3ce45e53bd38e75743033de",
"mergeBaseOid": "c9ab9334130c3905da9da27ce1960f53fbeff3d1",
"lastPushDate": "2024-02-20T04:17:47.000Z",
"lastActivityDate": "2024-02-26T19:38:09.000Z",
"mergeOfferDate": "2024-02-26T18:06:49.000Z",
"mergeRequestDate": "2024-02-26T19:38:08.000Z",
"mergeRequestUser": "IncognitaDev",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "instafeed.js",
"kind": "add",
"files": [
{
"path": "types/instafeed.js/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/instafeed.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/instafeed.js/instafeed.js-tests.ts",
"kind": "test"
},
{
"path": "types/instafeed.js/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/instafeed.js/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"IncognitaDev"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-26T19:38:09.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-02-26T18:06:08.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1953463770,
"ciResult": "pass"
}
🔔 @IncognitaDev — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)
@jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@peterblazejewicz, @jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@IncognitaDev The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@IncognitaDev The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@jakebailey, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
@IncognitaDev: Everything looks good here. I am ready to merge this PR (at 15452f3) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?
Ready to merge