fix(randomstring): autocomplete charset value
As per the documentation:
https://github.com/klughammer/node-randomstring?tab=readme-ov-file#api
This PR fixes the autocomplete for the charset property of the generate function, by intersecting string with never.
This fix still allows a string as a value.
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>.
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <
> - [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.
@noook Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners or DT maintainers
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68602,
"author": "noook",
"headCommitOid": "037a0cbd99320c54f0cb55e219868702e49a04b9",
"mergeBaseOid": "34d578b332507af7aeedfc084a9e37c63d0593b0",
"lastPushDate": "2024-02-12T17:00:30.000Z",
"lastActivityDate": "2024-02-27T22:17:09.000Z",
"mergeOfferDate": "2024-02-27T21:55:11.000Z",
"mergeRequestDate": "2024-02-27T22:17:09.000Z",
"mergeRequestUser": "noook",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "randomstring",
"kind": "edit",
"files": [
{
"path": "types/randomstring/index.d.ts",
"kind": "definition"
},
{
"path": "types/randomstring/randomstring-tests.ts",
"kind": "test"
}
],
"owners": [
"isman-usoh"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-02-27T21:54:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1939152233,
"ciResult": "pass"
}
🔔 @isman-usoh — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
Re-ping @isman-usoh:
This PR has been out for over a week, yet I haven't seen any reviews.
Could someone please give it some attention? Thanks!
@noook: Everything looks good here. I am ready to merge this PR (at 037a0cb) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@isman-usoh: you can do this too.)
Ready to merge