DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

feat(gtag.js): update item interface

Open KsAkira10 opened this issue 2 years ago • 5 comments

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: ga4 - reference
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.

KsAkira10 avatar Sep 19 '22 20:09 KsAkira10

@KsAkira10 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 8 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62331,
  "author": "KsAkira10",
  "headCommitOid": "89489b5c5f1592133434c7b0728726ea8efe1236",
  "mergeBaseOid": "c3924fd0016c953e1c4440f102436694442b7a57",
  "lastPushDate": "2022-09-20T22:42:13.000Z",
  "lastActivityDate": "2022-10-04T20:43:19.000Z",
  "mergeOfferDate": "2022-09-26T18:29:04.000Z",
  "mergeRequestDate": "2022-10-04T20:43:19.000Z",
  "mergeRequestUser": "KsAkira10",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "gtag.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/gtag.js/gtag.js-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gtag.js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rokt33r"
      ],
      "addedOwners": [
        "KsAkira10"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-09-26T18:28:18.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1251511497,
  "ciResult": "pass"
}

typescript-bot avatar Sep 19 '22 20:09 typescript-bot

🔔 @rokt33r — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar Sep 19 '22 20:09 typescript-bot

@KsAkira10 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot avatar Sep 20 '22 20:09 typescript-bot

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot avatar Sep 20 '22 22:09 typescript-bot

please rollback change to CODEOWNERS file, this is created by automate process,

thanks!

@peterblazejewicz Thanks for reviewing! I just reversed the file.

Could you check it out again, please?

KsAkira10 avatar Sep 20 '22 22:09 KsAkira10

Can anyone see this PR?

KsAkira10 avatar Sep 23 '22 11:09 KsAkira10

Let's give the current DT owner a day to react, ping me when it's still non reviewed, thanks!

peterblazejewicz avatar Sep 23 '22 18:09 peterblazejewicz

🔔 @rokt33r — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Please, could you review my PR?

KsAkira10 avatar Sep 26 '22 14:09 KsAkira10

@KsAkira10: Everything looks good here. I am ready to merge this PR (at 89489b5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@rokt33r: you can do this too.)

typescript-bot avatar Sep 26 '22 18:09 typescript-bot

LGTM!

@KsAkira10 thanks!

Thanks for your help!

KsAkira10 avatar Sep 26 '22 18:09 KsAkira10

Anyone?

KsAkira10 avatar Oct 04 '22 13:10 KsAkira10

@KsAkira10 please comment as per bot comment:

Ready to merge

peterblazejewicz avatar Oct 04 '22 20:10 peterblazejewicz

Ready to merge

KsAkira10 avatar Oct 04 '22 20:10 KsAkira10