feat: update url-state@3
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
npm test <package to test>.
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jessetane/url-state/commit/f06e058c807fe9ad4c05c0728ac785e3d5270a55
- [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
@tpluscode Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners, DT maintainers or others
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Inactive
This PR has been inactive for 39 days — closed because it wasn't merged for a long time!
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 62285,
"author": "tpluscode",
"headCommitOid": "7ede6724d9cd9268356529e7f2620400bfaa35aa",
"mergeBaseOid": "a0b2018c8f4ed391fae95aa6f0d9d642a6cd2074",
"lastPushDate": "2022-09-15T15:10:55.000Z",
"lastActivityDate": "2023-01-05T20:39:36.000Z",
"mergeOfferDate": "2023-01-05T20:39:15.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "url-state",
"kind": "edit",
"files": [
{
"path": "types/url-state/index.d.ts",
"kind": "definition"
},
{
"path": "types/url-state/url-state-tests.ts",
"kind": "test"
}
],
"owners": [
"tpluscode"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-01-05T20:38:27.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1248241841,
"ciResult": "pass"
}
🔔 @tpluscode — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)
@tpluscode: Everything looks good here. I am ready to merge this PR (at 7ede672) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
Not sure why it slipped under the bot radar (should had moved into unreviewed category long time ago), sorry!
After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.