DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

Add typings for time-limit-promise package

Open jameswassink opened this issue 3 years ago • 2 comments

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [x ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [x ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x ] Represents shape of module/library correctly
  • [x ] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [x ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

jameswassink avatar Aug 11 '22 11:08 jameswassink

@jameswassink Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

  • time-limit-promise (new!) — on npm, on unpkg
    • 1 added owner: ✎@jameswassink

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61663,
  "author": "jameswassink",
  "headCommitOid": "a87aa6643cd8186f65cc3109d50f4321dd880d28",
  "mergeBaseOid": "df84da363a5a1524b1d772eb0337700d4295e165",
  "lastPushDate": "2022-08-11T11:13:14.000Z",
  "lastActivityDate": "2022-08-15T00:19:37.000Z",
  "mergeOfferDate": "2022-08-12T20:15:04.000Z",
  "mergeRequestDate": "2022-08-15T00:19:37.000Z",
  "mergeRequestUser": "jameswassink",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "time-limit-promise",
      "kind": "add",
      "files": [
        {
          "path": "types/time-limit-promise/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/time-limit-promise/time-limit-promise-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/time-limit-promise/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/time-limit-promise/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "jameswassink"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-08-12T20:14:19.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1211851441,
  "ciResult": "pass"
}

typescript-bot avatar Aug 11 '22 11:08 typescript-bot

🔔 @jameswassink — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

typescript-bot avatar Aug 11 '22 11:08 typescript-bot

@jameswassink: Everything looks good here. I am ready to merge this PR (at a87aa66) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

typescript-bot avatar Aug 12 '22 20:08 typescript-bot

Ready to merge

jameswassink avatar Aug 15 '22 00:08 jameswassink