Update html-to-text version 8.1.0+ was Pr/58922
-
[x] Use a meaningful title for the pull request. Include the name of the package modified.
-
[x] Test the change in your own code. (Compile and run.)
-
[x] Add or edit tests to reflect the change.
-
[x] Follow the advice from the readme.
-
[x] Avoid common mistakes.
-
[x] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
-
[ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
This expands on the previous PR with two more changes.
- the 8.2.0 version of html-to-text broke the test of a deprecated feature. The test is updated to bypass the issue.
- the options that can be passed to selectors were intended to be user extensible. That feature is now available.
@webstech Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners or DT maintainers
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 61107,
"author": "webstech",
"headCommitOid": "7391c3aba2157d9e4c173217481a1949b71c3b67",
"mergeBaseOid": "45c020177bb0a24d03beccdc9917f3122949aa3a",
"lastPushDate": "2022-07-06T16:36:38.000Z",
"lastActivityDate": "2022-08-15T19:50:13.000Z",
"mergeOfferDate": "2022-08-15T19:50:56.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "html-to-text",
"kind": "edit",
"files": [
{
"path": "types/html-to-text/html-to-text-tests.ts",
"kind": "test"
},
{
"path": "types/html-to-text/index.d.ts",
"kind": "definition"
}
],
"owners": [
"erykwarren",
"CarsonF",
"webstech"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2022-08-15T19:50:13.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1175781369,
"ciResult": "pass"
}
🔔 @erykwarren @CarsonF — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
@webstech The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@webstech The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
I had not realized #59157 implemented the abandoned #58922. The second commit gets around this issue. The third commit allows any values for options as identified in #231 and #223.
It has been more than two weeks and this PR still has no reviews.
I'll bump it to the DT maintainer queue. Thank you for your patience, @webstech.
(Ping @erykwarren, @CarsonF.)