Hangjie Mo

Results 80 comments of Hangjie Mo

Maybe support for `indexMerge` and `UnionScan` can be added, it seems we are not considering global indexes in those related codes. Also we need to consider the support of the...

> @Defined2014, for the global index, should there be some way to specify placement rules? I don't think there are any for normal indexes? I think it will follow table's...

> > I think it will follow table's placement rules and it is in line with my expectations. What do you think @mjonss ? And we could add some test...

@dveeden I found you already pushed a [PR](https://github.com/pingcap/mysql-tester/pull/49) for `--let`, are you free to check does it still work or not? If the answer is yes, maybe we could merge...

> @Defined2014 [ ] Support error check code, like #52 you mean? Oh, yes, is it still working fine on the master branch now? @mjonss

> After checking out this branch and merging `upstream/master` into it and building it I get this: > > ``` > $ ./mysql-tester > ERRO[0000] run test [example] err: sql:SELECT...

I think maybe you could stop the ntp services in `WSL2` or change it same as Windows'.

> I think also https://docs.pingcap.com/tidb/stable/partitioned-table, https://docs.pingcap.com/tidb/stable/use-tiflash-mpp-mode and https://docs.pingcap.com/tidb/stable/tiflash-upgrade-guide also needs updating? I'll do this when we remove `static prune mode`, maybe v9.2. In v8.5 I only mentioned that it will...

> > > I think also https://docs.pingcap.com/tidb/stable/partitioned-table, https://docs.pingcap.com/tidb/stable/use-tiflash-mpp-mode and https://docs.pingcap.com/tidb/stable/tiflash-upgrade-guide also needs updating? > > > > > > I'll do this when we remove `static prune mode`, maybe v9.2....

> > > > > I think also https://docs.pingcap.com/tidb/stable/partitioned-table, https://docs.pingcap.com/tidb/stable/use-tiflash-mpp-mode and https://docs.pingcap.com/tidb/stable/tiflash-upgrade-guide also needs updating? > > > > > > > > > > > > I'll do this...