testenvironment-docker icon indicating copy to clipboard operation
testenvironment-docker copied to clipboard

Adds Oracle and Firebird containers with associated tests

Open PhenX opened this issue 4 years ago • 7 comments

This project may be a good option for integration tests for the https://github.com/fluentmigrator/fluentmigrator so I started working a on new containers types, please tell me if everything is ok in my code :)

PhenX avatar Sep 30 '20 17:09 PhenX

Hi @PhenX , awesome contribution, let us review and merge!

Deffiss avatar Oct 04 '20 19:10 Deffiss

I've just noticed Oracle test is failed on AppVeyor, let's try to find out the reason.

Deffiss avatar Oct 04 '20 19:10 Deffiss

One thing to check and be mindful of with timezones is whether you're using a linux distribution that ships time zones and locales. Time zones in Alpine Linux require installing tzdata otherwise you just get UTC

jzabroski avatar Oct 21 '20 02:10 jzabroski

https://serverfault.com/questions/949991/how-to-install-tzdata-on-a-ubuntu-docker-image I see in your yaml that you have ubuntu

jzabroski avatar Oct 21 '20 02:10 jzabroski

@PhenX , in case you haven't solved it yet. it might be the image being used by the CI/CD agent doesn't have time zones initialized. This is the case when using MySQL image for Windows. I had to build my own images and upload to docker hub but it worked. It is worth the pain

dgvives avatar Dec 28 '20 15:12 dgvives

@PhenX , in case you haven't solved it yet. it might be the image being used by the CI/CD agent doesn't have time zones initialized. This is the case when using MySQL image for Windows. I had to build my own images and upload to docker hub but it worked. It is worth the pain

Thanks for your help, David! @dgvives We're hoping to use TestEnvironment.Docker in FluentMigrator repo to do large integration tests against all the various database drivers available in .NET Core.

jzabroski avatar Jan 04 '21 00:01 jzabroski

@PhenX it seems downgrading package Oracle.ManagedDataAccess.Core to version 2.12.0-beta3 solves this issue https://github.com/Deffiss/testenvironment-docker/pull/48/commits/c8c068bd7b916a8c370360a8e22f42c6e017ac1f https://ci.appveyor.com/project/Deffiss/testenvironment-docker/builds/37139506

Also, using Oracle.DataAccess.Core may solve this, but I haven't found this package. Same for setting TZ environment variable within the container.

Hope this brings some help for this fine contribution.

Edit:

Just dll from package is required. https://github.com/Deffiss/testenvironment-docker/pull/48/commits/2d39e9b669abb26d516ef8d3e237d9f6d885a789 https://ci.appveyor.com/project/Deffiss/testenvironment-docker/builds/37140305

dgvives avatar Jan 06 '21 17:01 dgvives