django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Published 20 hours ago • verified publisher icon DefectDojo

Update mysql Docker tag from 5.7.39 to v8 (docker-compose.yml)

Open renovate[bot] opened this issue 3 years ago • 7 comments

Mend Renovate

This PR contains the following updates:

Package Update Change
mysql major 5.7.39 -> 8.0.30

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • [ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Aug 10 '22 12:08 renovate[bot]

I'm surprised that everything is green...

damiencarol avatar Aug 10 '22 17:08 damiencarol

I remember there being s big reason why we did not make this move sooner, but why exactly is escaping me. @mtesauro do you remember?

Maffooch avatar Aug 10 '22 18:08 Maffooch

@Maffooch The way DB user accounts are stored is different between 5x and 8x - the last time I looked at this it basically broke easy compose-based upgrades. Required manual steps that I don't recall the specifics of TBH.

I'm also surprised that the tests were green on this one.

mtesauro avatar Aug 11 '22 02:08 mtesauro

Could it be that the new version of the container have some auto migration thing that help? Should we spend time on this?

damiencarol avatar Aug 11 '22 06:08 damiencarol

@damiencarol Given that the tests passed (and used to not pass), it's probably worth spending some time on MySQL 8

I'm not sure I'll have time to test this much over the next week or two but if someone can, that would be great.

mtesauro avatar Aug 11 '22 15:08 mtesauro

@mtesauro Also I was thinking that as v5 and v8 are very different we could maybe have 2 tests. keep the one for v5 and create a new one for v8

damiencarol avatar Aug 12 '22 09:08 damiencarol

@damiencarol Interesting idea - sure why not give it a try.

mtesauro avatar Aug 12 '22 16:08 mtesauro

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 8.x releases. However, if you upgrade to 8.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

renovate[bot] avatar Sep 30 '22 18:09 renovate[bot]