django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Fix parser horusec

Open srburton opened this issue 2 years ago • 1 comments

I'm doing this update because when trying to import a report from Horusec you get the following error:

WhatsApp Image 2022-07-01 at 14 06 30

I noticed that the reports of the new version of Horusec the "line" comes empty where it ends up breaking the parser of the integer:

WhatsApp Image 2022-07-01 at 14 09 19

Screenshot_2

srburton avatar Jul 14 '22 21:07 srburton

Ok @Maffooch

renatosazup-zz avatar Jul 19 '22 12:07 renatosazup-zz

@srburton @renatosazup : the comment of @Maffooch is still there, we need a unit test with a report that don't have the line (empty value) to show that the fix works.

damiencarol avatar Aug 15 '22 18:08 damiencarol

@damiencarol added unit test!

srburton avatar Aug 15 '22 23:08 srburton

@srburton Thanks for the new scan report!

Please test against it in the horusec unit test file here

Maffooch avatar Aug 16 '22 20:08 Maffooch

@Maffooch check my fix, please?

srburton avatar Aug 18 '22 01:08 srburton

@damiencarol leaving merge to you if it looks good

Maffooch avatar Aug 18 '22 22:08 Maffooch