django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

<WIP> Add the ability to the UI to delete engagements from the engagement tab

Open coheigea opened this issue 3 years ago • 2 comments

The products and findings tabs have three vertical dots that allow you to edit/delete/etc., however these are missing from the engagements tab. So if you go to "All Engagements" for example you can't delete an engagement.

This PR adds the three vertical dots for "All Engagements", "Active Engagements" and "Engagements by Product"

coheigea avatar Jul 05 '22 07:07 coheigea

Still seeing the z-index issue here, but the menu can be scrolled to show the whole dropdown image

Maffooch avatar Aug 15 '22 14:08 Maffooch

Yeah I tried and failed to find a way to display it outside of the list

coheigea avatar Aug 15 '22 14:08 coheigea

@blakeaowens is going to try to fix the zindex issue.

devGregA avatar Sep 30 '22 18:09 devGregA

There's still a bug in active engagements, this time if you scroll down the page the 3 dots remain in situ:

Screenshot 2022-10-26 at 12 13 15

coheigea avatar Oct 26 '22 11:10 coheigea

@coheigea if this PR is still in progress, you can mark it as a draft.

damiencarol avatar Oct 26 '22 19:10 damiencarol

There's still a bug in active engagements, this time if you scroll down the page the 3 dots remain in situ:

Screenshot 2022-10-26 at 12 13 15

blakeaowens avatar Oct 26 '22 23:10 blakeaowens

@coheigea I will have another look later this evening.

blakeaowens avatar Oct 26 '22 23:10 blakeaowens

engagements-dropdowns

blakeaowens avatar Oct 28 '22 03:10 blakeaowens

LGTM thanks @blakeaowens

coheigea avatar Oct 29 '22 10:10 coheigea