django-DefectDojo
django-DefectDojo copied to clipboard
[FIX] Issues on disconnection and connection using Social Auth
Fix two issues that appear when SOCIAL_AUTH and "SHOW_LOGIN_FORM = False" are combined (no /login form):
- When disconnecting, as return URL is not /login and does not contains next parameter, an error 500 is triggered.
- When connecting, message "You have logged out" is displayed after logging in.
@X0x1RG9f how to test it, to trigger error, can be it replicated using SAML auth?
@X0x1RG9f how to test it, to trigger error, can be it replicated using SAML auth?
@dsever I don't know if it can be replicated with SAML. Test is easy, activating the two parameters in my first post. SOCIAL AUTH (I used Gsuite) and "SHOW_LOGIN_FORM = False". Then, when you are logged in and try to logout, you will trigger a 500 error.
@X0x1RG9f how to test it, to trigger error, can be it replicated using SAML auth?
@dsever I don't know if it can be replicated with SAML. Test is easy, activating the two parameters in my first post. SOCIAL AUTH (I used Gsuite) and "SHOW_LOGIN_FORM = False". Then, when you are logged in and try to logout, you will trigger a 500 error.
Ok, I will give a try.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
@X0x1RG9f thank you for the PR. Looks good. Will merge after the release for further testing.