django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Add dynamic Test_Type for Generic parser

Open damiencarol opened this issue 2 years ago • 5 comments

Implement new interface for parser to customize Test_Type.

  • [x] Add feature to customize test_type (useful to use generic type for multiple different parser and have a different de-duplication algorithm for each test_type)
  • [x] Don't force active/verified value

image

damiencarol avatar Feb 27 '22 16:02 damiencarol

This looks good to me, but the dedupe test appears to be a logic failure rather than a deployment failure

Maffooch avatar Feb 28 '22 17:02 Maffooch

Might be related to active/verified changes?

valentijnscholten avatar Feb 28 '22 19:02 valentijnscholten

Some code was changed (in good) by Stephan to support better dynamic Test_type, I think some integration tests need modifications, the PR is not ready

damiencarol avatar Mar 02 '22 18:03 damiencarol

mmm. this is weird. I checked and it's a fail in another parser :/ "Immuniweb Scan" Relaunching the unit tests

damiencarol avatar Mar 03 '22 16:03 damiencarol

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 01 '22 12:06 github-actions[bot]

@damiencarol is this ready to be moved from draft to PR?

devGregA avatar Sep 30 '22 18:09 devGregA

@damiencarol are you still working / interested in this one?

devGregA avatar Nov 04 '22 18:11 devGregA

This can be closed because it was merged in https://github.com/DefectDojo/django-DefectDojo/pull/7471

kiblik avatar Jan 23 '23 22:01 kiblik