pdb2sql icon indicating copy to clipboard operation
pdb2sql copied to clipboard

Refactor StructureSimilarity

Open NicoRenaud opened this issue 1 year ago • 2 comments

StructureSimilarity is a bit of a mess now. We have different ways of computing the metrics and they don't all have the same features and internal checks :

  • Some routines check for residue and atom matching some don't
  • Some routines accept multiple chains some don't

We want a unified API for all metrics such as :

def compute_x(self, chain_pairs=None, xzone=None, method='svd', check=True, name=['CA','C','N','O'] ):

NicoRenaud avatar Oct 03 '22 12:10 NicoRenaud

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 04 '22 04:11 github-actions[bot]

I would like to have the option to select the chain IDs in. https://github.com/DeepRank/pdb2sql/blob/76d7b684b6921261436e2656d9ecd8be86148199/pdb2sql/StructureSimilarity.py#L531

Right now, it always picks the first two.

cbaakman avatar May 02 '24 13:05 cbaakman