DeepRank
Variant queries requesting redudant inputs
Currently, we are requesting as inputs for variant queries (among other things): number, insertion code, wt aa, var aa. At least one of those is redundant because it can be read directly from the pdb. If we do ask for all inputs, then I think the reason would be to avoid mistakes, and in that case we should send an error (or warning?) if it doesn't match.
See original discussion on the topic here: Originally posted by @DaniBodor in https://github.com/DeepRank/deeprank2/pull/459#discussion_r1277337220
In response to this: I actually believe it is the wt and not the variant that is listed in the pdb. At least that seems to be the case in our test scripts. Either way, one of the two is redundant.
Come to think of it, currently, the user can input both a wt and a variant aa, neither of which is the one listed in the pdb (and it doesn't crash). Is this something that we want to allow? I'm not sure what happens in this case, but what I guess is that the listed aa is just ignored altogether.
This issue is stale because it has been open for 30 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
See further the points raised here. This is all related to each other:
https://github.com/DeepRank/deeprank2/pull/492#issuecomment-1732423764
This issue is stale because it has been open for 30 days with no activity.