deeprank2 icon indicating copy to clipboard operation
deeprank2 copied to clipboard

Use pathlib or os.join method and global TEST_PATH variable consistently in test modules

Open DaniBodor opened this issue 2 years ago • 1 comments

From this comment (see below for examples):

We can either:

Use forward slashes (/) or commas (,) with pathlib functions - both options work. The Path() object will convert forward slashes or commas into the correct kind of slash for the current operating system (nice blog post about it [here](https://medium.com/@ageitgey/python-3-quick-tip-the-easy-way-to-deal-with-file-paths-on-windows-mac-and-linux-11a072b58d5f#:~:text=You%20should%20use%20forward%20slashes,operator%20directly%20in%20your%20code.)).
Use os.path.join() method.

Furthermore: We could adjust the TEST_PATH variable to TESTDATA_PATH and use 1 fewer folder level in the data, as there is no added benefit of having (nearly) identically named folders to the final file.

DaniBodor avatar Apr 05 '23 14:04 DaniBodor

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar May 08 '23 03:05 github-actions[bot]