deeprank2 icon indicating copy to clipboard operation
deeprank2 copied to clipboard

Use openMM to redefine the forcefield

Open DaniBodor opened this issue 2 years ago • 5 comments

This has multiple advantages:

  • allows optional (and correct) generation of hydrogens in pdb structures based on predicted protonation state
  • allows determining 1-3 and 1-4 pairings for nonbond energy calculation
  • more accurate/useful/?? forcefield?

DaniBodor avatar Mar 17 '23 16:03 DaniBodor

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Apr 21 '23 03:04 github-actions[bot]

Following up on this after today's meeting, we decided to give high priority to modifying the package to be able to read in pdb files with hydrogens generated with @joaomcteixeira's code.

  • Did I understand correctly that you used amber forcefield instead of OPLS, the one we have in the deeprank2 package @joaomcteixeira?
  • If yes, isn't it possible to change the openMM parameter to the OPLS forcefield, so that then we're aligned with the package?

Also, @LilySnow asked to use @joaomcteixeira's code to calculate pairwise energies such as electrostatic and van der waals after we updated the forcefield. Reflecting on it now, to me it's not clear why is this needed, since we've already these features. For sure I'd need more context.

gcroci2 avatar Nov 01 '23 16:11 gcroci2

Following up on this after today's meeting, we decided to give high priority to modifying the package to be able to read in pdb files with hydrogens generated with @joaomcteixeira's code.

  • Did I understand correctly that you used amber forcefield instead of OPLS, the one we have in the deeprank2 package @joaomcteixeira?

OPLS is old, so it's recommended to replace it

gcroci2 avatar Nov 02 '23 15:11 gcroci2

Also, @LilySnow asked to use @joaomcteixeira's code to calculate pairwise energies such as electrostatic and van der waals after we updated the forcefield. Reflecting on it now, to me it's not clear why is this needed, since we've already these features. For sure I'd need more context.

We need Joao's code because we will not use anymore the param file for vdw, but we will use OpenMM directly for computing pair-wise energies. See this PR https://github.com/DeepRank/pdbprep/pull/12

gcroci2 avatar Nov 02 '23 15:11 gcroci2

Hi,

Yes, all the code I did is in the https://github.com/DeepRank/pdbprep repository.

Regarding interface atom-atom pairwise energy calculation using OpenMM it is all in the https://github.com/DeepRank/pdbprep/pull/12, as you mentioned. Let me know if something is not clear in the documentation of the code or the code itself.

Best wishes,

joaomcteixeira avatar Nov 02 '23 15:11 joaomcteixeira

This is done in pdbprep repository, but deeprank2 still uses OPLS forcefield without OpenMM. Integration of this into deeprank2 will be handled by #509

gcroci2 avatar Jun 27 '24 14:06 gcroci2