deeprank2 icon indicating copy to clipboard operation
deeprank2 copied to clipboard

Refactor duplicate code

Open DaniBodor opened this issue 3 years ago • 4 comments

  • utils/graph.py: build_atomic_graph / build_residue_graph

  • features/surfacearea.py:

    • add_sasa_for_residues and add_sasa_for_atoms
    • add_sasa and and_bsa can be fused
    • test_surfacearea has duplicate code
  • query.py:

    • SingleResidueVariantResidueQuery and SingleResidueVariantAtomicQuery
    • ProteinProteinInterfaceAtomicQuery and ProteinProteinInterfaceResidueQuery
    • also check for overlapping code between SingleResidueVariant and ProteinProteinInterface type classes
  • likely in other places as well

    • there's often duplicate code for atomic and residue level graphs

DaniBodor avatar Nov 25 '22 14:11 DaniBodor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 30 '22 03:12 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jan 06 '23 03:01 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jan 18 '23 03:01 github-actions[bot]

was automatically closed, but not done. I will reopen it now

DaniBodor avatar Jan 24 '23 10:01 DaniBodor