deep-motion-editing icon indicating copy to clipboard operation
deep-motion-editing copied to clipboard

Input data shape

Open phj128 opened this issue 2 years ago • 2 comments

Hi, thanks for your wonderful work. When I am reading your code carefully, I find that the input data offsets have the shape [4, 23, 3] while motion has the shape [4, 91, 156]. So the offsets have the shape [B, J, S] and motion has the shape [B, (J - 1) * Q + S, T], where Q = 4 and S = 3. If the last three is the position of the root, where is its rotation? I am new to this field, could you please help me with this? Thank you.

phj128 avatar Sep 28 '21 13:09 phj128

Hi, thank you for your question. In retargeting part we use edge representation of the animation, where the root joint rotations in original joint representation is actually stored in the edges that are connected to the root joint.

PeizhuoLi avatar Oct 04 '21 16:10 PeizhuoLi

Hi, sorry to bother you again. I have noticed that in your code preprocessing the motion data in this line: https://github.com/DeepMotionEditing/deep-motion-editing/blob/master/retargeting/datasets/bvh_parser.py#L205 you choose the rotation of the edge[0] of the skeleton. However, for the joints connected with the root, (like 1, 9, 5 for example in 22 joints number) these joints' rotations are the same as the root rotation. I don't really understand why their rotations should be root rotations. The same situation also happens in joint 12 which connects the head and two arms. I would appreciate it if you could help me with this.

phj128 avatar Dec 17 '21 01:12 phj128