vscode-extension icon indicating copy to clipboard operation
vscode-extension copied to clipboard

false negatives on type properties on custom objects

Open JustFly1984 opened this issue 4 years ago • 5 comments

Hello @deepcodeg I have a lot of false negatives on "type" fields of custom objects in my typescript code, and ignore comments do not resolve it.

Screenshot 2020-06-12 04 36 47 Screenshot 2020-06-12 04 38 09 Screenshot 2020-06-12 04 38 46 Screenshot 2020-06-12 04 40 40

even in redux reducer (immer)

Screenshot 2020-06-12 04 54 39

Thank you for great plugin, it improves development experience.

JustFly1984 avatar Jun 11 '20 21:06 JustFly1984

one more issue I have found: Screenshot 2020-06-12 14 05 22

cy.get() returns promise-like object, not the promise, so it has no catch chaining. I already have an eslint ignore next line comment.

The issue is If I'm adding deepcode ignore comment, it disables functionality of eslint comment by moving it up. Can deepcode interoperate with eslint?

JustFly1984 avatar Jun 12 '20 07:06 JustFly1984

Hello @JustFly1984, thank you for you feedback. We managed to reproduce this issue and will work on fixing it and update you once it's done.

As for linter. We have a non-documented way. Pls try to add deepcode's comment in the same line or below. Our engine should catch it.

Arvi3d avatar Jun 12 '20 08:06 Arvi3d

@Arvi3d I do not really want to bloat the codebase with comments, cos it is around 300+ warnings, and I better wait till it will be fixed on your side. Thank you!

JustFly1984 avatar Jun 13 '20 20:06 JustFly1984

@Arvi3d I've got a bunch of new false negatives for you today:

  • 1 Screenshot 2020-06-16 03 55 29

here it is a clearly bug, somehow it thinks that {count >= 10 ? '9+' : count} is variable assignment, btw to const, which should be illegal in first place, so later in the code it thinks that count is type of string with value "9+"

  • 2 Screenshot 2020-06-16 04 07 18

here it thinks that Set is not used, but it is used in for of cycle.

  • 3 And I constantly see connection errors, and it heats my macbook pro pretty hard: Screenshot 2020-06-16 04 10 35

so I've disabled it again for a while.

JustFly1984 avatar Jun 15 '20 21:06 JustFly1984

Currently I confirm bugs fixed, except PromiseLike (without catch) for cypress, and string literal "9+"

JustFly1984 avatar Jun 23 '20 21:06 JustFly1984