fabricatr icon indicating copy to clipboard operation
fabricatr copied to clipboard

rename join()

Open jaspercooper opened this issue 6 years ago • 4 comments

It's a pretty key function in dplyr that we don't want to conflict with

jaspercooper avatar Oct 24 '18 02:10 jaspercooper

Any thoughts on this @nfultz @aaronrudkin?

graemeblair avatar Oct 24 '18 05:10 graemeblair

What do you want it called instead?

nfultz avatar Oct 24 '18 15:10 nfultz

join_levels ?

On 24 Oct 2018 11:56, "Neal Fultz" [email protected] wrote:

What do you want it called instead?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DeclareDesign/fabricatr/issues/160#issuecomment-432715857, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJO_ZNowYLIIVFPTT1qQ4fM0hMqf4bxks5uoI2kgaJpZM4X2_m4 .

macartan avatar Oct 24 '18 16:10 macartan

It doesn't take levels, but unquoted variable names. maybe join_by or join_on.

nfultz avatar Oct 24 '18 16:10 nfultz