super-gradients icon indicating copy to clipboard operation
super-gradients copied to clipboard

DagsHub Logger: Fix unsupported metric formats for MLflow, Add example notebook

Open nirbarazida opened this issue 1 year ago • 2 comments

MLflow doesn't support some of the formats YOLO-NAS uses, so we either reformat them or raise an expiration that this format is not supported and will not be logged. This way, if YOLO-NAS uses a metric we didn't encounter during our tests and is not supported by MLflow, the training process will not stop, and the user will get an informative error message about it.

nirbarazida avatar May 04 '23 17:05 nirbarazida

Hey @ofrimasad, I fixed the issue you mentioned, can this be merged in now?

Thanks, Dean

deanp70 avatar Jun 11 '23 11:06 deanp70

@BloodAxe we reviewed and fixed your comments on the unsupported symbols. Please let me know if there's anything else, or if we can go ahead and merge this in. Thanks in advance! 🙏

deanp70 avatar Jun 26 '23 06:06 deanp70

@BloodAxe / @ofrimasad Fixed both comments. Is it possible to merge now?

Also, could I hope it's ok with you, but if you do find any additional changes – would it be possible to review the entire contribution, since doing it a couple of fixes at a time is much more time-consuming?

Thanks in advance, appreciate the consideration 🙏

deanp70 avatar Jul 11 '23 07:07 deanp70

Hi @ofrimasad @BloodAxe

We've fixed all comments and ran a few tests to check the "happy path" works and other edge cases. Is it possible to merge now?

nirbarazida avatar Jul 25 '23 08:07 nirbarazida

Hey @BloodAxe @ofrimasad Did you have a chance to review the changes? We want to promote the integration on our channels but waiting for the fixes to be merged.

nirbarazida avatar Aug 08 '23 07:08 nirbarazida