DecentHolograms icon indicating copy to clipboard operation
DecentHolograms copied to clipboard

DecentHolograms incompatible with future Paper versions

Open kennytv opened this issue 1 year ago • 2 comments

Just making sure

  • [X] I made sure, this bug is not already known or reported.
  • [X] I believe, that this bug is fixable.

Reproduction

Run https://github.com/PaperMC/testing/releases/tag/no-relocation, start with DecentHolograms

Solution

See https://forums.papermc.io/threads/paper-velocity-1-20-4.998/#post-2955

Server Version

1.20.4

Client Version

1.20.4

Plugin Version

2.8.6

Log

https://paste.gg/p/anonymous/4ea996af04484343b25fc55ba1c368e5

kennytv avatar Jan 25 '24 13:01 kennytv

Looking at the code, the only problem I can see is updating the Version class... This could be relatively simple, but may require to find out every possible output of Bukkit.getServer().getBukkitVersion() down to 1.8 to create proper changes to use as it seems to be a get package name -> check with enum of version patterns thing used here.

Perhaps getting the Bukkit version, doing some string transformations (i.e. split at - and use first part and replace dots with _) could already go a long way here... But again would we need to know all versions that the plugin should support and their respecive Bukkit version output... :/

Andre601 avatar Jan 25 '24 16:01 Andre601

Seems they've pulled the trigger on this.

https://forums.papermc.io/threads/important-dev-psa-future-removal-of-cb-package-relocation.1106/

Looks like the affected line is https://github.com/DecentSoftware-eu/DecentHolograms/blob/e6ac39a4a0d1644e3c724dd7f94f1106196e04a7/src/main/java/eu/decentsoftware/holograms/api/utils/reflect/ReflectionUtil.java#L90

chxseh avatar May 03 '24 02:05 chxseh

Hello, a workaround has been implemented in version 2.8.7. Thank you for letting us know about this!

d0by1 avatar May 18 '24 20:05 d0by1