vitamin-web icon indicating copy to clipboard operation
vitamin-web copied to clipboard

Published 20 hours ago • verified publisher icon Decathlon

bug(@vtmn/css): `rating` (interactive) is not switching colors in dark mode

Open samueldelaporte opened this issue 2 years ago • 2 comments

In interactive mode, the rating component's color is not adapting in dark mode

Capture d’écran 2022-06-13 à 11 13 14 Capture d’écran 2022-06-13 à 11 12 56

and applying the css class vtmn-rating_variant--brand has no effect.

samueldelaporte avatar Jun 13 '22 09:06 samueldelaporte

Thanks @samueldelaporte for raising this issue. We will investigate soon.

GaspardMathon avatar Jun 14 '22 07:06 GaspardMathon

Hi @samueldelaporte thanks for reporting this. That's a big work that we need to do because the interactive is not constructed as same as the classic rating. We will keep you informed in this issue in Vitamin v1 because of a lot of breaking changes. Sorry for the inconvenience.

lauthieb avatar Jun 27 '22 14:06 lauthieb

This fix won't be fixed now. But we will make a reference to this issue in the next version of the component.

GaspardMathon avatar Oct 27 '22 15:10 GaspardMathon