vitamin-ios icon indicating copy to clipboard operation
vitamin-ios copied to clipboard

feat: Dynamic Vitamix Image Asset

Open SayadiMohamedOmar opened this issue 1 year ago β€’ 5 comments

The purpose of this issue is to give access to the app who is using Vitamix Asset to fetch the assets based on the name of the image so we can use them based on the configuration which will be provided by our app.

Example: the method provided by vitamin for fetching country by region code. public static func flag(countryCode: String) -> VitaminAsset?

SayadiMohamedOmar avatar Mar 13 '23 14:03 SayadiMohamedOmar

Hello @SayadiMohamedOmar, Thanks for your improvement request.

Can you give us more information about how you imagine the naming? Country flags are a little different because a country code is a worldwide naming convention, there is no naming like that for icons.

Do we agree on something like the name of the icon on Figma with -fill or -line suffix? (Ex: home-fill and home-line)

florentlotthepro avatar Mar 14 '23 12:03 florentlotthepro

Hello @florentlotthepro
yes i think it will be great if we use the icon name of Figma like you mentioned πŸ™πŸΎπŸ‘ŒπŸΏ

SayadiMohamedOmar avatar Mar 17 '23 14:03 SayadiMohamedOmar

Hello @mackoj, What is your opinion on that?

florentlotthepro avatar Mar 22 '23 14:03 florentlotthepro

I think it's a great idea.

mackoj avatar Mar 22 '23 16:03 mackoj

I will add it to my ticket for the next major version of vitamin.

mackoj avatar Mar 22 '23 16:03 mackoj