SRP icon indicating copy to clipboard operation
SRP copied to clipboard

Boxes & cases config fixes and cleanup

Open SurDno opened this issue 4 years ago • 0 comments

Boxes and cases are clearly a mess. In Shadow of Chernobyl there was one item that was allowed on a certain location but never included in any kind of box — Gauss rifle. In Clear Sky, there are dozens of such mistakes.

My assumption is there has been a certain conflict with developers' intentions, because the only allowed items types are ammo and medsupplies, yet there are boxes that give only grenades, weapons and artifacts. And the placement of these boxes clearly suggests that game designers intended them to be a rare reward of sorts. I went through artifact and weapon boxes (since grenade ones are somewhat common), just look at this:

List of big_box_dungeons and big_box_arsenal boxes per location and descriptions of how hard to reach they are

image Great Swamps - mar_physic_destroyable_object_0059 - a box on the roof of one of the northern farmstead buildings. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Dark Valley - val_physic_destroyable_object_0038 - a box hidden in the tunnel with the anomaly with a ton of other empty boxes. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Dark Valley - val_physic_destroyable_object_0056 - a box hidden in the deserted part of the factory. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Dark Valley - val_physic_destroyable_object_0059 - a box hidden in the deserted part of the factory. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Yantar - yan_physic_destroyable_object_0019 - a box hidden on top of the part of the factory that is just filled with psy emission. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Yantar - yan_physic_destroyable_object_0021 - a box hidden right on the roof of the factory (which is, again, filled with psy emission). Not easily reachable, rewards exploration, supposed to drop weapons, drops nothing.

image Red Forest - red_physic_destroyable_object_0071 - a box hidden in the end of the shaft. Somewhat easily reachable, rewards a little exploration, supposed to drop artifacts, drops nothing.

image Military Warehouses - mil_physic_destroyable_object_0038 - a box placed at one of the bloodsucker village houses. Somewhat easily reachable, rewards a little exploration, supposed to drop weapons, drops nothing.

image Military Warehouses - mil_physic_destroyable_object_0039 - a box hidden in the basement of one of the bloodsucker village houses. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Military Warehouses - mil_physic_destroyable_object_0041 - a box placed right in the middle of the anomaly field. Not easily reachable, rewards exploration, supposed to drop artifacts, drops nothing.

image Military Warehouses - mil_physic_destroyable_object_0047 - a case placed on the roof of one of bloodsucker village buildings. Not easily reachable, rewards exploration, supposed to drop weapons, drops nothing.

image Military Warehouses - mil_physic_destroyable_object_0049 - a case placed on the roof of one of bloodsucker village buildings. Not easily reachable, rewards exploration, supposed to drop weapons, drops nothing.

image Limansk - lim_physic_destroyable_object_0058, lim_physic_destroyable_object_141, lim_physic_destroyable_object_142, lim_physic_destroyable_object_144 -four boxes (two are stacked into each other) hidden in some sort of Limansk basement. Somewhat easily reachable, reward exploration (knowing the fact that the level is linear), supposed to drop weapons, drop nothing.

image Limansk - lim_physic_destroyable_object_0137, lim_physic_destroyable_object_0138, lim_physic_destroyable_object_0139, lim_physic_destroyable_object_0140 - four boxes (two are stacked into each other) hidden in the same basement. Somewhat easily reachable, reward exploration (knowing the fact that the level is linear), supposed to drop weapons, drop nothing.

image Limansk - lim_physic_destroyable_object_0143, lim_physic_destroyable_object_0145, lim_physic_destroyable_object_0146 - three boxes hidden on the way to the time machine easter egg. Not easily reachable, reward exploration, supposed to drop weapons, drop nothing.

image Limansk - lim_physic_destroyable_object_0147 - four boxes (two are stacked into each other) hidden in the same basement. Somewhat easily reachable, rewards exploration (knowing the fact that the level is linear), supposed to drop weapons, drops nothing.

image Hospital - katacomb_physic_destroyable_object_0102 - a box hidden under the stairs. Somewhat easily reachable, rewards exploration (knowing the fact that the level is linear), supposed to drop weapons, drops nothing.

Apart from that, there are a lot of big_box_generic boxes (those that drop grenades) that are not hidden or anything, but the amount of them is enormous. There are 44 such boxes in Limansk, which clearly shows that devs wanted to supply you with some grenades here.

Despite all the aforementioned evidence that these boxes giving some sort of loot was clearly what devs intended, I thought that SRP should stick close to the behaviour presented in vanilla game and just cleaned up items that never drop from these boxes to make configuration files more or less readable.

Fixes:

  • Fixed Military Warehouses random boxes dropping nothing due to entry for the location being missing in ph_box_items_by_communities.ltx.
  • Fixed no boxes dropping minigun ammo even though it's clearly been intended to be dropped on Red Forest and ongoing levels.
  • Fixed 'science' boxes dropping army medkits. As evident from SoC, they are supposed to give scientific medkits only, but 'ussr' boxes, which 'science' boxes are based on, had army medkits added in CS as probable drop and later not excluded from 'science' boxes.

Cleanup:

  • Sorted everything alphabetically, the way it has been done in trade configuration files cleanup.
  • Removed all never-dropped-items from ph_box_items_communities.ltx.
  • Removed all SoC levels from ph_box_items_by_levels.ltx.
  • Removed all never-dropped-items from ph_box_items_count.ltx.

SurDno avatar Jul 09 '20 12:07 SurDno