Angular-NgRx-GettingStarted icon indicating copy to clipboard operation
Angular-NgRx-GettingStarted copied to clipboard

Published 20 hours ago • verified publisher icon DeborahK

Toggle password not working?

Open yringler opened this issue 2 years ago • 2 comments

This must be on me, but I don't see what I might be doing wrong. I did the "homework" for module 4, and the password wasn't becoming visible. Then I tried the original version - also not. Did something change in browser security recently? Checked firefox and chrome. I'm probably going to find tomorrow that I made a silly mistake, IDK.

yringler avatar Nov 22 '22 01:11 yringler

So - despite the words "Mask USER NAME" being clearly in the UI, it never occurred to me that there would be an option to mask anything other than a password 😆 Would you take a PR to have the toggle work on the password field?

yringler avatar Nov 23 '22 12:11 yringler

Glad you resolved the issue!

At this time, we want the code here to match what's covered in the course, so we aren't taking PRs.

We do update the course from time to time and will include your feedback.

Thanks for posting your resolution!

DeborahK avatar Nov 23 '22 17:11 DeborahK